Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIA support for Keychron C1 Pro #1912

Merged
merged 63 commits into from
Jul 1, 2023
Merged

Conversation

KeychronMacro
Copy link
Contributor

Added VIA JSONs for Keychron C1 Pro and request for a review, Thanks!

Description

  • Added c1_pro/c1_pro_ansi_rgb.json to v3/keychron.
  • Added c1_pro/c1_pro_ansi_white.json to v3/keychron.

QMK Pull Request

qmk/qmk_firmware#20700

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

KeychronMacro and others added 30 commits October 13, 2022 16:53
Add VIA support for Keychron Q3
Add VIA JSONs for Keychron q8
Adapt the number of light effects to the current definition in qmk master.
Adapt the number of light effects to the current definition in qmk master.
Update the light effects definition to keep up with regular Q0(rev_0130) when PR(Add new board rev_0131 for Keychron Q0 #19547) is merge into qmk master.
v3/keychron/c1_pro/c1_us_rgb_v1.2.json Outdated Show resolved Hide resolved
v3/keychron/c1_pro/c1_us_white_v1.2.json Outdated Show resolved Hide resolved
@Xelus22 Xelus22 merged commit 5231c80 into the-via:master Jul 1, 2023
@KeychronMacro KeychronMacro deleted the keychron-c1_pro branch July 3, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants