Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 definition for era/divine #1991

Merged
merged 4 commits into from
Aug 19, 2023
Merged

Add v2 definition for era/divine #1991

merged 4 commits into from
Aug 19, 2023

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Aug 18, 2023

Description

When loading v3 definition in the latest Vial-based firmware, a "Fetching v2 definition failed" error occurred.
It seems that v2 definition needs to be added to use both Vial and Via.
Could you please allow this?

QMK Pull Request

qmk/qmk_firmware#21593

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Add support for era/divine
Delete src/divine
Adds v2 definition for compatibility with Vial-based firmware.
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have a V3 definition already, I'll allow it.

@Xelus22 Xelus22 merged commit 338546c into the-via:master Aug 19, 2023
2 checks passed
@eerraa
Copy link
Contributor Author

eerraa commented Aug 19, 2023

@Xelus22
Thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants