Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 definition for era/sirind/klein #2086

Closed
wants to merge 1 commit into from

Conversation

eerraa
Copy link
Contributor

@eerraa eerraa commented Nov 21, 2023

Add v2 definition for era/sirind/klein_sd & era/sirind/klein_hs

Description

To resolve the "Fetching v2 definition failed" error message when using vial firmware, adding v2 definition is required.
I would like permission for this.

QMK Pull Request

qmk/qmk_firmware#22371
qmk/qmk_firmware#22203

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

To resolve the “Fetching v2 definition failed” error message
@Xelus22
Copy link
Collaborator

Xelus22 commented Dec 2, 2023

To resolve the "Fetching v2 definition failed" error message when using vial firmware, adding v2 definition is required.
I would like permission for this.

You would need to use a newer VIAL update then. Please use that. There are no official QMK firmwares with older versions.

@Xelus22 Xelus22 closed this Dec 2, 2023
@eerraa
Copy link
Contributor Author

eerraa commented Dec 2, 2023

@Xelus22
So far, the same error occurs even with the latest Vial firmware. :(
Could you please allow merging of v2 definitions?
Last time, I solved this problem by allowing you to add v2 definition.
#1991

@Xelus22
Copy link
Collaborator

Xelus22 commented Dec 2, 2023

Ah it uses the old version... :/ id prefer not to have overlap there due to potential issues for both yourself and your customers. That was an exception. We really want to move away from older things with newer nicer macros (with delays) and encoders in V3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants