Formally introduce arguments[2] as newConfig #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The 3rd argument (appropriately named newConfig) in the constructor is used when we are instantiating error from the error class returned by makeError(), which binds the first 2 arguments of ApolloError to the first 2 arguments of makeError(). newConfig should take precedent when merging with config
lxcid
force-pushed
the
lxcid/error-config
branch
from
ac9baa9
to
1471719
Compare
lxcid
changed the title
|
Sorry updated the PR to reflected the new changes. |
This was referenced Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3rd argument (appropriately named newConfig) in the constructor is used when we are instantiating error from the error class returned by makeError(), which binds the first 2 arguments of ApolloError to the first 2 arguments of makeError().
newConfig should take precedent when merging with config