Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formally introduce arguments[2] as newConfig #34

Closed
wants to merge 1 commit into from
Closed

Formally introduce arguments[2] as newConfig #34

wants to merge 1 commit into from

Commits on Mar 27, 2018

  1. Formally introduce arguments[2] as newConfig 

    Summary:

The 3rd argument (appropriately named newConfig) in the constructor is used when we are instantiating error from the error class returned by makeError(), which binds the first 2 arguments of ApolloError to the first 2 arguments of makeError().

newConfig should take precedent when merging with config
    @lxcid
    lxcid committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    1471719 View commit details
    Browse the repository at this point in the history