Fixes #28243 - upgrade vendor to v3 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2019
adamruzicka
reviewed
Nov 20, 2019
sharvit
force-pushed
the
feat/vendor-v3
branch
from
2d5ab7b
to
b6ac2a3
Compare
|
Rebased, it should fix the linting issue |
sharvit
force-pushed
the
feat/vendor-v3
branch
from
b6ac2a3
to
47df571
Compare
|
Updated to use |
jeremylenz
approved these changes
Nov 25, 2019
sharvit
force-pushed
the
feat/vendor-v3
branch
from
47df571
to
74a1378
Compare
|
Why is Jenkins not happy? Shows 0 failures |
|
The tests are failing because of rubocop. #480 needs to get in first and this PR needs to be rebased on top of that |
sharvit
force-pushed
the
feat/vendor-v3
branch
from
74a1378
to
067939a
Compare
|
Thanks, rebased! |
|
Thanks @sharvit and @adamruzicka, merging this and will release 1.0.0 for nightlies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main upgrades are redux-hooks. babel v7 and jest v24