Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nodejs-theforeman-vendor to 3.0.0 #4330

Closed
wants to merge 1 commit into from
Closed

Bump nodejs-theforeman-vendor to 3.0.0 #4330

wants to merge 1 commit into from

Conversation

sharvit
Copy link

@sharvit sharvit commented Nov 12, 2019 •
edited
Loading

@sharvit
Copy link
Author

sharvit commented Nov 12, 2019

Any idea what if wrong?

@sharvit sharvit mentioned this pull request Nov 13, 2019
Closed
@xprazak2
Copy link

Node packages were moved to scl, but the newer version of npm2rpm that reflects this change has not been released, so it updates your spec for the non-scl version.

@ekohl
Copy link
Member

ekohl commented Nov 13, 2019 •
edited
Loading

So we've updated npm2rpm to output specs that can work with SCL in order to support a more modern nodejs but currently rely on an unreleased version. If you generate this with the master version, it should work.

Edit: I should have read @xprazak2's comment.

@tbrisker tbrisker mentioned this pull request Nov 13, 2019
Closed
@sharvit
Copy link
Author

sharvit commented Nov 13, 2019

Thanks @ekohl @xprazak2

I followed @xprazak2 instructions

@sharvit
Copy link
Author

sharvit commented Nov 13, 2019

It's green :)

@tbrisker
Copy link
Member

should this be closed in favor of #4348 or update to get 3.1?

@sharvit
Copy link
Author

sharvit commented Nov 19, 2019

Yes @tbrisker thanks, closing.

@sharvit sharvit closed this Nov 19, 2019
@sharvit sharvit deleted the rpm/vendor-v3 branch November 19, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xprazak2 xprazak2 xprazak2 left review comments

Assignees
No one assigned
Labels
Needs testing Not yet reviewed RPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharvit @xprazak2 @ekohl @tbrisker @theforeman-bot