Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #28229 - upgrade babel and jest #7164

Closed
wants to merge 2 commits into from
Closed

Fixes #28229 - upgrade babel and jest #7164

wants to merge 2 commits into from

Conversation

sharvit
Copy link
Contributor

@sharvit sharvit commented Nov 10, 2019

What this PR does:

Blocked by #6981

@theforeman-bot
Copy link
Member

Issues: #28229

@sharvit sharvit added Blocked by another PR Waiting on Packaging PRs that shouldn't be merged until packaging side is merged labels Nov 10, 2019
@jeremylenz
Copy link
Contributor

Can this new babel config give us the ability to use

<>
...
</>

instead of

<React.Fragment>
...
</React.Fragment>

?

(I've noticed it doesn't work currently and I think it was something to do with Babel understanding that JSX.)

@sharvit
Copy link
Contributor Author

sharvit commented Nov 12, 2019

@jeremylenz I think it can be done with a babel plugin. I would prefer to do so in a different PR, maybe in the env package

@sharvit sharvit mentioned this pull request Nov 12, 2019
Closed
amirfefer and others added 2 commits November 14, 2019 11:41
@sharvit sharvit mentioned this pull request Nov 20, 2019
Closed
evgeni
evgeni reviewed Nov 20, 2019
View reviewed changes
package.json
"babel-eslint": "^8.2.3",
"babel-jest": "^23.6.0",
"babel-loader": "^7.1.1",
"@babel/cli": "^7.7.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to package those? because we don't have babel 7.x packaged so far

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or is this just for dev setup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you packaged any babel before? You need them for the webpack build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice there is a WIP to move them to a separate package:
#7178

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The babel packages changed their names from v6 to v7
It used to be babel-core and now it's @babel/core

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we only have babel-core (and friends) in 6.26 packaged, not 7.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

@sharvit
Copy link
Contributor Author

sharvit commented Nov 21, 2019

Instead of merging this PR, it makes more sense merging #7178

@sharvit
Copy link
Contributor Author

sharvit commented Dec 3, 2019

Closing, merged here: #7178

@sharvit sharvit closed this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni left review comments

Assignees
No one assigned
Labels
Blocked by another PR Needs testing Not yet reviewed UI Waiting on Packaging PRs that shouldn't be merged until packaging side is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharvit @theforeman-bot @jeremylenz @evgeni @amirfefer