Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #28255 - upgrade vendor to v3 #446

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Fixes #28255 - upgrade vendor to v3 #446

merged 1 commit into from
Dec 19, 2019

Conversation

sharvit
Copy link
Contributor

@sharvit sharvit commented Nov 12, 2019

Main upgrades are redux-hooks and babel v7

houndci-bot
houndci-bot reviewed Nov 12, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js 
Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
Error: Cannot find module 'node_modules/@theforeman/vendor-dev/eslint.extends.js'
Referenced from: .eslintrc
Error: Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/resolve-from/index.js:14:16)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/require-uncached/index.js:11:17)
    at loadJSConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:154:16)
    at loadConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:209:22)
    at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:495:18)
    at load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
    at configExtends.reduceRight (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:425:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:403:26)

@sharvit sharvit mentioned this pull request Nov 12, 2019
Closed
@adamruzicka
Copy link
Contributor

[test foreman_remote_execution]

adamruzicka
adamruzicka reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, rekicking the tests to see what the failures are about

houndci-bot
houndci-bot reviewed Nov 24, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js 
Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
Error: Cannot find module 'node_modules/@theforeman/vendor-dev/eslint.extends.js'
Referenced from: .eslintrc
Error: Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/resolve-from/index.js:14:16)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/require-uncached/index.js:11:17)
    at loadJSConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:154:16)
    at loadConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:209:22)
    at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:495:18)
    at load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
    at configExtends.reduceRight (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:425:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:403:26)

houndci-bot
houndci-bot reviewed Nov 24, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js 
Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
Error: Cannot find module 'node_modules/@theforeman/vendor-dev/eslint.extends.js'
Referenced from: .eslintrc
Error: Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/resolve-from/index.js:14:16)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/require-uncached/index.js:11:17)
    at loadJSConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:154:16)
    at loadConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:209:22)
    at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:495:18)
    at load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
    at configExtends.reduceRight (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:425:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:403:26)

@sharvit
Copy link
Contributor Author

sharvit commented Nov 24, 2019

Updated to use @theforeman/babel

houndci-bot
houndci-bot reviewed Dec 3, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js 
Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
Error: Cannot find module 'node_modules/@theforeman/vendor-dev/eslint.extends.js'
Referenced from: .eslintrc
Error: Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/resolve-from/index.js:14:16)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/require-uncached/index.js:11:17)
    at loadJSConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:154:16)
    at loadConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:209:22)
    at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:495:18)
    at load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
    at configExtends.reduceRight (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:425:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:403:26)

@ekohl ekohl mentioned this pull request Dec 10, 2019
Merged
ekohl
ekohl reviewed Dec 10, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase this to fix the rubocop issues?

.gitignore Outdated
@@ -13,3 +13,4 @@ locale/*/*.edit.po
locale/*/*.po.time_stamp
Gemfile.lock
node_modules/
package-lock.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure there's a newline char at the end?

houndci-bot
houndci-bot reviewed Dec 11, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js 
Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
Error: Cannot find module 'node_modules/@theforeman/vendor-dev/eslint.extends.js'
Referenced from: .eslintrc
Error: Cannot read config file: node_modules/@theforeman/vendor-dev/eslint.extends.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/resolve-from/index.js:14:16)
    at module.exports (/home/linters/app/versions/eslint-4.19.1/node_modules/require-uncached/index.js:11:17)
    at loadJSConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:154:16)
    at loadConfigFile (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:209:22)
    at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:495:18)
    at load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
    at configExtends.reduceRight (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:425:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:403:26)

@sharvit
Copy link
Contributor Author

sharvit commented Dec 11, 2019

thanks @ekohl, rebased and updated the .gitignore

adamruzicka
adamruzicka approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, ACK

@ares
Copy link
Member

ares commented Dec 19, 2019

Thanks @sharvit and @adamruzicka, merging and will follow with a 3.0.0 release!

@ares ares merged commit 2542232 into theforeman:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@ekohl ekohl ekohl left review comments

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sharvit @adamruzicka @ares @ekohl @houndci-bot @theforeman-bot