-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scroll to behave similar to interactors docs #865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work. Looks really smooth and the markup is clean:
What do we think about the rounded header? It matches the interactors, but I think square might be more 2024 Thoughts? |
maybe only bottom corners make rounded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just go with square for right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6097209
to
33de960
Compare
@wKich What alternatives to we have to making the header and app wrappers know about what route they're rendering? I'm a bit uncomfortable making the Can we use a form of render props? |
@cowboyd Could you please check it? |
@wKich Having an I think we have a couple of options. One would be to use a context to add navlinks. {yield* extraNavlinks([]) } Another, would be to use a render prop for the app html |
Oh, ok. So you mean to pass nav links into header and form them outside? |
Yes. That way the container doesn't need to be aware of the content. Same way that the children are rendered into the body without needing to know what they are. |
e3696b0
to
a27bf16
Compare
Apologies for the delay. I'm going to make sure I get this through because we're almost there. The `Guides' link is missing on the docs page (even though it would link back to itself). In other words, the links should not "flash" when you navigate between sections of the website as they move from one place to the other. The space should be allocated beforehand, and if you are in the mobile guides, then the burger appears. Instead of passing the navlinks all through, made even have a "navmenu" property that will allocate that spot? |
@wKich Mainly, what we want to avoid is the menu "flashing" and re-arranging when you click links. |
I see what you mean about it being very squished. What about taking out the |
@cowboyd can we go ahead and merge this? |
It still looks bad on mobile. I think we have to move the v3 from the header on mobile. |
Ok, I’ll take a look.
… On Feb 16, 2024, at 12:30 PM, Charles Lowell ***@***.***> wrote:
@cowboyd <https://github.com/cowboyd> can we go ahead and merge this?
It still looks bad on mobile. I think we have to move the v3 from the header on mobile.
—
Reply to this email directly, view it on GitHub <#865 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASHP433COM6TPEA36FCTLYT6JUXAVCNFSM6AAAAABA2IVBD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBYHE2TGMJTGM>.
You are receiving this because your review was requested.
|
@cowboyd Removed "v3" from the header. Sorry for delay |
Ok, let's rebase and go. |
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
666cfbb
to
4a3fa90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go here. Squashing them into a single commit is optional as long as the commits that we have tell a coherent story.
Motivation
@cowboyd:
Approach
useAppHtml.tsx