Configure Nav items based on context #887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
Signed-off-by: Dmitriy Lazarev <[email protected]>
wKich
force-pushed
the
dl/fix-docs-scroll-styles
branch
from
666cfbb
to
4a3fa90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#865 is held up because the AppHTML component needs to know Nav-specific things. I wanted to get it unblocked.
Approach
Introduce
DocsContext- a boolean that evaluates to true when in Docs. I use this in the header to determine where to show the Nav header items.I was initially trying to wrap the operation in another to set the context. This felt natural because that's how I would do it in React. In Effection, I can override the context in the operation where I need it overwritten, which is much more convenient.