fix: ensure questions that set a data field with no option data values are not automated #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
commented
Nov 4, 2024
| ); | ||
| if (!visitedFns) return; | ||
| if (!visitedFns.length) return; |
There was a problem hiding this comment.
A filter is always going to return an [] so the previous condition incorrectly always returned true!
DafyddLlyr
approved these changes
Nov 4, 2024
| ); | ||
| if (!visitedFns) return; | ||
| if (!visitedFns.length) return; |
Comment on lines
+315
to
+322
| validate: ({ options, ...values }) => { | ||
| const errors: FormikErrors<FormikValues> = {}; | ||
| if (values.fn && !options?.some((option) => option.data.val)) { | ||
| errors.fn = | ||
| "At least one option must set a data value when the checklist has a data field"; | ||
| } | ||
| return errors; | ||
| }, |
There was a problem hiding this comment.
nit: It would be nice to make these validation schemas for ease of expansion in future, but this could well be a YAGNI thing - they've been without any validation for a very long time!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes edge case flagged here: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1730455691984869
Two changes:
autoAnswerableOptionscondition is corrected so that existing nodes will behave as expected (put to user)Testing: