Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (take 2): ensure questions that set a data field with no option data values are not automated #3930

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Nov 11, 2024

Follows on from #3903 (which was reverted via #3915)

See thread here https://opensystemslab.slack.com/archives/C01E3AC0C03/p1730884655361309

Original solution was failing to automate property.localAuthorityDistrict & property.region questions because these data fields are not stored under fn in FindProperty.

Copy link

github-actions bot commented Nov 11, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review November 11, 2024 11:47
@jessicamcinchak jessicamcinchak requested a review from a team November 11, 2024 11:47
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple!

@jessicamcinchak jessicamcinchak merged commit 4323e4e into main Nov 11, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the revert-3915-revert-3903-jess/editor-data-field-validation-bug branch November 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants