Fix incorrectly overriden static type-hint in Reader and AbstractCsv #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
The following code produces this Phan error:
PhanUndeclaredMethod Call to undeclared method \League\Csv\AbstractCsv::setHeaderOffset
:Proposal
Remove the static return type-hint from
AbstractCsv
since sub-classes now overridecreateFromPath()
.Backward Incompatible Changes
None
Targeted release version
9.1.2
Open issues
There's some references to this in #266