Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly overriden static type-hint in Reader and AbstractCsv #285

Merged
merged 3 commits into from
Mar 5, 2018
Merged

Fix incorrectly overriden static type-hint in Reader and AbstractCsv #285

merged 3 commits into from
Mar 5, 2018

Commits on Mar 3, 2018

  1. Ignore .php_cs.cache

    Sam Stenvall committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    652c59e View commit details
    Browse the repository at this point in the history

  2. Remove static return type-hint from createFromPath() 

    The type-hint says "@return static", which means if you call Reader::createFromPath() it should return a Reader, not an AbstractCsv. Without this you can't use any of the methods provided by Reader without getting warnings during static analysis.
    Sam Stenvall committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    8b3063b View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Remove static return type-hints from other "createFrom" methods too

    Sam Stenvall committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    3cc811d View commit details
    Browse the repository at this point in the history