Upgrade end func #177
Assignees
Milestone
Comments
ragboyjr
added a commit
that referenced
this issue
Nov 30, 2017
- Updated the end func to multi-purpose and just simply end the output buffering - Updated the start func to utilize the new end func and perform the start section semantics Signed-off-by: RJ Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The end func semantics need to change.
Let's keep the end func simple so that all it needs to do is just stop the output buffering so that we can reuse the end func in several different places (like #175 or #176)
So, i'm picturing that the section_def structure looks like this: [$ob_level, $callback]. So, the end func simply will perform the validations like it does now, but instead of appending the sections, it should just fire the callback with the contents from the output buffer.
We'll then need to move the code for updating the sections into the start func as a callback.
The text was updated successfully, but these errors were encountered: