Upgrade End Func #177 #178

ragboyjr · 2017-11-30T04:16:53Z

Updated the end func to multi-purpose and
just simply end the output buffering
Updated the start func to utilize the
new end func and perform the start section
semantics

Signed-off-by: RJ Garcia [email protected]

- Updated the end func to multi-purpose and just simply end the output buffering - Updated the start func to utilize the new end func and perform the start section semantics Signed-off-by: RJ Garcia <[email protected]>

Nitpick-CI · 2017-11-30T04:17:03Z

src/RenderContext/func.php

@@ -28,43 +28,51 @@ function sectionFunc() {

 /** Starts the output buffering for a section, update of 0 = replace, 1 = append, 2 = prepend */
 function startFunc($update = START_REPLACE) {
-    return function(FuncArgs $args) use ($update) {
-        $section_def = $args->template->getContextItem('_section_def') ?: [];
+    return startBufferFunc(function(FuncArgs $args) use ($update) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:04Z

src/RenderContext/func.php

-    return function(FuncArgs $args) use ($update) {
-        $section_def = $args->template->getContextItem('_section_def') ?: [];
+    return startBufferFunc(function(FuncArgs $args) use ($update) {
+        return function($contents) use ($update, $args) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:04Z

src/RenderContext/func.php


-        ob_start();
-        $section_def[] = [$args->args[0], $update, ob_get_level()];
+function startBufferFunc(callable $create_callback) {


Opening brace should be on a new line

Nitpick-CI · 2017-11-30T04:17:04Z

src/RenderContext/func.php

-        ob_start();
-        $section_def[] = [$args->args[0], $update, ob_get_level()];
+function startBufferFunc(callable $create_callback) {
+    return function(FuncArgs $args) use ($create_callback) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:05Z

test/func.spec.php

@@ -1,45 +1,132 @@
 <?php

+use League\Plates\{


There must be one USE keyword per declaration

Nitpick-CI · 2017-11-30T04:17:05Z

test/func.spec.php

+    Exception\FuncException
+};
+
+use function Eloquent\Phony\{on, mock};


There must be one USE keyword per declaration

Closing brace must be on a line by itself

Nitpick-CI · 2017-11-30T04:17:06Z

test/func.spec.php

+};
+
+use function Eloquent\Phony\{on, mock};
+use function League\Plates\{


There must be one USE keyword per declaration

Nitpick-CI · 2017-11-30T04:17:06Z

test/func.spec.php

+    Template\getSections,
+    Util\stack
+};
+use function League\Plates\RenderContext\{


There must be one USE keyword per declaration

Nitpick-CI · 2017-11-30T04:17:06Z

test/func.spec.php

+    startBufferFunc,
+    endFunc
+};
+use const League\Plates\RenderContext\{


There must be one USE keyword per declaration

Nitpick-CI · 2017-11-30T04:17:07Z

test/func.spec.php

-});
-xdescribe('platesFunc', function() {
-    it('creates the default plates func stack');
+describe('Funcs', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:07Z

test/func.spec.php

-xdescribe('platesFunc', function() {
-    it('creates the default plates func stack');
+describe('Funcs', function() {
+    beforeEach(function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:07Z

test/func.spec.php

+        $this->template = new Template('');
+        $this->args = new FuncArgs($this->render, $this->template, '', []);
+    });
+    describe('layoutFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:08Z

test/func.spec.php

+    describe('layoutFunc', function() {
+        it('forks a template and sets the layout');
+    });
+    xdescribe('sectionFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:08Z

test/func.spec.php

+    xdescribe('sectionFunc', function() {
+        it('gets a section from the template sections');
+    });
+    describe('startFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:09Z

test/func.spec.php

+        it('gets a section from the template sections');
+    });
+    describe('startFunc', function() {
+        $create_test = function($update_text, $update, $expected) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:09Z

test/func.spec.php

+    });
+    describe('startFunc', function() {
+        $create_test = function($update_text, $update, $expected) {
+            it("can start buffering and {$update_text} the section", function() use ($update, $expected) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:09Z

test/func.spec.php

+        $create_test('append', START_APPEND, 'bazbar');
+        $create_test('prepend', START_PREPEND, 'barbaz');
+    });
+    describe('startBufferFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:10Z

test/func.spec.php

+        $create_test('prepend', START_PREPEND, 'barbaz');
+    });
+    describe('startBufferFunc', function() {
+        it('starts the output buffering and appends the buffer_stack', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:10Z

test/func.spec.php

+    describe('startBufferFunc', function() {
+        it('starts the output buffering and appends the buffer_stack', function() {
+            $args = $this->args;
+            $callback = function() {};


Expected 1 space after FUNCTION keyword; 0 found

Closing brace must be on a line by itself

Nitpick-CI · 2017-11-30T04:17:11Z

test/func.spec.php

+            $callback = function() {};
+
+            $cur_level = ob_get_level();
+            startBufferFunc(function($passed_args) use ($args, $callback) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:11Z

test/func.spec.php

+            ob_end_clean();
+        });
+    });
+    describe('endFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:11Z

test/func.spec.php

+        });
+    });
+    describe('endFunc', function() {
+        it('throws an exception if no buffer_stack have been defined', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:12Z

test/func.spec.php

+    describe('endFunc', function() {
+        it('throws an exception if no buffer_stack have been defined', function() {
+            $func = endFunc();
+            expect(function() use ($func) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:12Z

test/func.spec.php

+                $func($this->args);
+            })->throw(FuncException::class, 'Cannot end a section definition because no section has been started.');
+        });
+        it('throws an exception if the output buffering level does not match the section def', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:12Z

test/func.spec.php

+        });
+        it('throws an exception if the output buffering level does not match the section def', function() {
+
+            startBufferFunc(function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:13Z

test/func.spec.php

+        it('throws an exception if the output buffering level does not match the section def', function() {
+
+            startBufferFunc(function() {
+                return function() {};


Expected 1 space after FUNCTION keyword; 0 found

Closing brace must be on a line by itself

Nitpick-CI · 2017-11-30T04:17:13Z

test/func.spec.php

+            ob_end_clean();
+
+            $func = endFunc();
+            expect(function() use ($func) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:13Z

test/func.spec.php

+                $func($this->args);
+            })->throw(FuncException::class, 'Output buffering level does not match when section was started.');
+        });
+        it('cleans the buffer and calls the callback', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:14Z

test/func.spec.php

+        });
+        it('cleans the buffer and calls the callback', function() {
+            $was_called = false;
+            startBufferFunc(function() use (&$was_called) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:14Z

test/func.spec.php

+        it('cleans the buffer and calls the callback', function() {
+            $was_called = false;
+            startBufferFunc(function() use (&$was_called) {
+                return function() use (&$was_called) {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:15Z

test/func.spec.php

+            expect($this->args->template->context['buffer_stack'])->length(0);
+        });
+    });
+    xdescribe('insertFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:15Z

test/func.spec.php

+    xdescribe('insertFunc', function() {
+        it('forks a template and echos the rendered contents');
+    });
+    xdescribe('escapeFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:15Z

test/func.spec.php

+    xdescribe('escapeFunc', function() {
+        it('it escapes the content with htmlspecialchars');
+    });
+    xdescribe('assertArgsFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:15Z

test/func.spec.php

+        it('passes through if there are enough args');
+        it('appends null to the args to make up the amount of required and defaulted args');
+    });
+    xdescribe('aliasNameFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:16Z

test/func.spec.php

+        it('passes through if no aliases are matched');
+        it('recursively aliases func names');
+    });
+    xdescribe('splitByNameFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI · 2017-11-30T04:17:16Z

test/func.spec.php

+        it('allows stacks to be invoked by func name');
+        it('passes through if no stack was registered per func name');
+    });
+    xdescribe('platesFunc', function() {


Expected 1 space after FUNCTION keyword; 0 found

Upgrade End Func #177

1404aeb

- Updated the end func to multi-purpose and just simply end the output buffering - Updated the start func to utilize the new end func and perform the start section semantics Signed-off-by: RJ Garcia <[email protected]>

Nitpick-CI reviewed Nov 30, 2017

View reviewed changes

test/func.spec.php

@@ -1,45 +1,132 @@

<?php

use League\Plates\{

Copy link

Nitpick-CI Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be one USE keyword per declaration

Nitpick-CI reviewed Nov 30, 2017

View reviewed changes

test/func.spec.php

};

use function Eloquent\Phony\{on, mock};

use function League\Plates\{

Copy link

Nitpick-CI Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be one USE keyword per declaration

Nitpick-CI reviewed Nov 30, 2017

View reviewed changes

test/func.spec.php

startBufferFunc,

endFunc

};

use const League\Plates\RenderContext\{

Copy link

Nitpick-CI Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be one USE keyword per declaration

Nitpick-CI reviewed Nov 30, 2017

View reviewed changes

test/func.spec.php

ob_end_clean();

});

});

describe('endFunc', function() {

Copy link

Nitpick-CI Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI reviewed Nov 30, 2017

View reviewed changes

test/func.spec.php

ob_end_clean();

$func = endFunc();

expect(function() use ($func) {

Copy link

Nitpick-CI Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 1 space after FUNCTION keyword; 0 found

Nitpick-CI reviewed Nov 30, 2017

View reviewed changes

ragboyjr merged commit 5996618 into v4.0-dev Nov 30, 2017

ragboyjr deleted the 177-upgrade-end-func branch November 30, 2017 04:22

Upgrade End Func #177 #178

Upgrade End Func #177 #178

Conversation

ragboyjr commented Nov 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment