M-05 _isPrimaryMarket Does Not Consider Bundled NFTs #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-05 _isPrimaryMarket Does Not Consider Bundled NFTs
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
capedcrusader21
force-pushed
the
marketplace-bundle/M-05-isPrimaryMarket-does-not-consider-bundled-nfts
branch
from
2cedff2
to
7533b58
Compare
capedcrusader21
force-pushed
the
marketplace-bundle/M-05-isPrimaryMarket-does-not-consider-bundled-nfts
branch
from
7533b58
to
c2c2266
Compare
capedcrusader21
requested review from
adjisb
and removed request for
a team
… add to fn clarity
Code cleanup for M-05
wojciech-turek
approved these changes
Sep 17, 2024
| remainder = _transferRoyalties(remainder, paymentSide, nftSide); | ||
| } | ||
| if (!isBundle) { | ||
| remainder = _transferProtocolFees(remainder, paymentSide, fees); |
There was a problem hiding this comment.
Small thing, after we merge other PRs to this lets add a comment above this line about why we do this
// Transfer protocol fees for non bundle asset, bundles pay per item protocol fees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added logic to apply the primary market fee and skip the royalties when creator sell bundled assets.
protocol fee is applied to individual prices of assets in bundle.
updated test cases for bundled exchange