Add argument to choose .env file encoding #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added argument for .env file encoding. Default encoding is UTF-8.
jamesmyatt
reviewed
Oct 8, 2018
| f = dotenv_path or stream or find_dotenv() | ||
| return DotEnv(f, verbose=verbose).set_as_environment_variables(override=override) | ||
| return DotEnv(f, verbose=verbose, encoding=encoding).set_as_environment_variables(override=override) |
There was a problem hiding this comment.
Have you considered just capturing the additional keyword arguments and passing them to the DotEnv constructor? That way you don't have to hard-code a default encoding in 3 different places.
theskumar
force-pushed
the
master
branch
2 times, most recently
from
f628767
to
f9863d3
Compare
This was referenced Jan 2, 2019
|
Superseded by #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added argument for .env file encoding. Default encoding is UTF-8.
This resolves #74, #121.