Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(logfile): improve log request tests #2260

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Sep 13, 2023

Proposed changes

Improve the log file request integration tests:

  • add library function to check service status of child devices and switch to new tedge interface
  • use recent timestamp instead of 1970 as this is more aligned to how the UI behaves
  • fix timestamp bug where the tests were using a fixed timezone which meant that the local time was being erroneously cast to UTC leading to unexpected dateFrom/dateTo values
  • use tedge config to control te topic instead of flags
  • add notes about when workarounds in tests can be removed

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

* use recent timestamp instead of 1970
* use tedge config to control te topic instead of flags
* add notes about when workaround can be removed

Signed-off-by: Reuben Miller <[email protected]>
@reubenmiller reubenmiller added the theme:troubleshooting Theme: Troubleshooting and remote control label Sep 13, 2023
@reubenmiller reubenmiller temporarily deployed to Test Pull Request September 13, 2023 12:53 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
273 0 5 273 100 56m15.240999999s

@reubenmiller
Copy link
Contributor Author

Closing as the changes have been merged into #2262 as that PR contained the Rust fixes which this test was covering (as well as some general test improvements on the same subject matter).

@reubenmiller reubenmiller deleted the chore-improve-log-request-tests branch July 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:testing theme:troubleshooting Theme: Troubleshooting and remote control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant