-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: plugins don't update their internal representation of config files on file change #2262
Merged
Ruadhri17
merged 7 commits into
thin-edge:main
from
Ruadhri17:fix-update-config-on-change-in-plugins
Sep 14, 2023
Merged
Fix: plugins don't update their internal representation of config files on file change #2262
Ruadhri17
merged 7 commits into
thin-edge:main
from
Ruadhri17:fix-update-config-on-change-in-plugins
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruadhri17
temporarily deployed
to
Test Pull Request
September 13, 2023 20:10
— with
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files
|
Robot Results
|
Signed-off-by: Reuben Miller <[email protected]>
* use recent timestamp instead of 1970 * use tedge config to control te topic instead of flags * add notes about when workaround can be removed Signed-off-by: Reuben Miller <[email protected]>
Signed-off-by: Krzysztof Piotrowski <[email protected]>
Signed-off-by: Krzysztof Piotrowski <[email protected]>
Signed-off-by: Krzysztof Piotrowski <[email protected]>
Signed-off-by: Reuben Miller <[email protected]>
…vice Signed-off-by: Reuben Miller <[email protected]>
reubenmiller
force-pushed
the
fix-update-config-on-change-in-plugins
branch
from
September 14, 2023 02:53
d5cb111
to
8e1b1c6
Compare
@Ruadhri17 I merged the changes from #2260 as the integration tests were covering this aspect, so we can get confirmation that everything works as expected before merging (I also rebased ontop of the latest from main) |
11 tasks
reubenmiller
temporarily deployed
to
Test Pull Request
September 14, 2023 03:07
— with
GitHub Actions
Inactive
albinsuresh
reviewed
Sep 14, 2023
The fix looks good. Happy to approve once my queries are addressed. |
albinsuresh
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the problem of not updating the internal representation of config files. This applies to all plugins that use
FsFileWatcher
:tedge-log-plugin
c8y-log-plugin
c8y-configuration-plugin
Additionally this PR fixes unsafe
unwrap
while sending mqtt message inside thec8y-configuration-plugin
(that could lead to rust panic if there was any problem with MQTT actor)The integration tests were also extended to cover these scenarios to ensure it functions as expected (taken from #2260):
te
topic instead of flagsTypes of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments