Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workflow added #745

Merged
merged 5 commits into from
Nov 17, 2022
Merged

chore: workflow added #745

merged 5 commits into from
Nov 17, 2022

Conversation

hdJerry
Copy link
Contributor

@hdJerry hdJerry commented Oct 28, 2022

Setup CI for new project

Background

We want to review changes in as near real-time as possible. The goal of this is to set up guard rails for development practices and validate features as they’re completed.

Acceptance

  • Setup linting
  • Setup Unit testing
  • Setup build

Notes

You can use existing CI workflows as a baseline

@hdJerry hdJerry self-assigned this Oct 28, 2022
@hdJerry hdJerry linked an issue Oct 28, 2022 that may be closed by this pull request
3 tasks
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-745.dbm2zhgk5abrj.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-745.d3sqkonra6x7y9.amplifyapp.com

@mbicknese
Copy link
Contributor

GitHub is still not picking up on the pipeline. We'll need to figure out what's missing.

@mbicknese
Copy link
Contributor

Oh wait, it only runs on the main branch! the path refers to which files it needs to look at. @hdJerry can you check what happens if we remove the branches filter?

@vyktoremario
Copy link
Contributor

@hdJerry where are we on this?

@hdJerry
Copy link
Contributor Author

hdJerry commented Nov 14, 2022

I will revert soon

@hdJerry
Copy link
Contributor Author

hdJerry commented Nov 14, 2022

I think we have to merge to main to see it it works for other branches, and if it doesn't we can create a ticket to fix.
@vyktoremario @mbicknese

@hdJerry hdJerry merged commit a2b1f66 into main Nov 17, 2022
@hdJerry hdJerry deleted the solidjs-tailwind/setup-ci branch November 17, 2022 12:45
hdJerry added a commit that referenced this pull request Nov 17, 2022
* chore: workflow added

* CI setup fixes and testing

* CI setup fixes and testing

* CI setup fixes and testing

* tried everything but doesn't work, i think we have to merge this
hdJerry added a commit that referenced this pull request Nov 17, 2022
* chore: workflow added

* CI setup fixes and testing

* CI setup fixes and testing

* CI setup fixes and testing

* tried everything but doesn't work, i think we have to merge this
hdJerry added a commit that referenced this pull request Nov 17, 2022
* in progress

* chore: get all repos api

* [Angular - NgRx - SCSS] 440: state & service refactor (#527)

* setup: get branch caught up and ready for work

* feat: refactored repository service and test

* feat: refactor of user service and test

* feat: updated user service spec

* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls

* attempt to fix issues with service updates; some refactoring and adjusting so app compiles

* feat: added auth user data to auth state; updated nav component to use auth state

* feat: adjusted auth call; fixed user call so home page loads

* moved some user logic; still having reload issues and repo view issues

* feat: got app working again! cleaned out console logs

* rebased and fixed most files

* fix broken tests

* removed unused code

* fix: fix pr comments and most tests

* fix: fixed final broken unit test

* fix: updated test; removed unused code in user effect; new user mapping file

* add todo for refactor improvements; update authUser effect to use different rxjs operation

Co-authored-by: LindaT <[email protected]>

* feat(solidjs) - Create navigation header (#840)

* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)

* fix(angular-apollo-tailwind): append protocol if missing from user url

Refs: #591

* test(angular-apollo-tailwind): update with testcases

Closes: #591

* chore: repo card with story and test (#737)

* chore: repo card with story and test

* fix comments

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore: gist panel UI (#741)

* chore: gist panel UI

* fix coment

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* [solidjs-pod] : Create component for search input and filter sort buttons (#831)

* in progress

* in progress

* in progress, paused for now

* chore: search filter sort component

* fixed comments on icons

* [solidjs-tailwinf] Add user profile card (#830)

* [SolidJS-Tailwind] Implement authentication (#734)

* chore(solidjs): remove example components

* feat(solidjs): add signin page

* refactor(solidjs): improve auth setup

* feat(solidjs): pencil in auth flow

* feat(solidjs): add example github communication

* [Angular - NgRx - SCSS] 440: state & service refactor (#527)

* setup: get branch caught up and ready for work

* feat: refactored repository service and test

* feat: refactor of user service and test

* feat: updated user service spec

* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls

* attempt to fix issues with service updates; some refactoring and adjusting so app compiles

* feat: added auth user data to auth state; updated nav component to use auth state

* feat: adjusted auth call; fixed user call so home page loads

* moved some user logic; still having reload issues and repo view issues

* feat: got app working again! cleaned out console logs

* rebased and fixed most files

* fix broken tests

* removed unused code

* fix: fix pr comments and most tests

* fix: fixed final broken unit test

* fix: updated test; removed unused code in user effect; new user mapping file

* add todo for refactor improvements; update authUser effect to use different rxjs operation

Co-authored-by: LindaT <[email protected]>

* feat(solidjs) - Create navigation header (#840)

* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)

* fix(angular-apollo-tailwind): append protocol if missing from user url

Refs: #591

* test(angular-apollo-tailwind): update with testcases

Closes: #591

* chore: repo card with story and test (#737)

* chore: repo card with story and test

* fix comments

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore: gist panel UI (#741)

* chore: gist panel UI

* fix coment

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore(solidjs): remove example components

* fixed comments, clean ups

Co-authored-by: Linda Thompson <[email protected]>
Co-authored-by: LindaT <[email protected]>
Co-authored-by: Daian Scuarissi <[email protected]>
Co-authored-by: Oluwakorede Cole <[email protected]>
Co-authored-by: Jerry Hogan <[email protected]>
Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore: updated amplify.yml file (#729)

* chore: updated amplify.yml file

* changed pnpm to npm

* chore: workflow added (#745)

* chore: workflow added

* CI setup fixes and testing

* CI setup fixes and testing

* CI setup fixes and testing

* tried everything but doesn't work, i think we have to merge this

* auth token added to header

* ..updates

* ..updates

* auth token added to header

* fix file issues

* CI adjustments

* CI adjustments

Co-authored-by: Linda Thompson <[email protected]>
Co-authored-by: LindaT <[email protected]>
Co-authored-by: Daian Scuarissi <[email protected]>
Co-authored-by: Oluwakorede Cole <[email protected]>
Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>
Co-authored-by: Maarten Bicknese <[email protected]>
hdJerry added a commit that referenced this pull request Nov 18, 2022
* chore: get gists api

* updated gists api function

* [Angular - NgRx - SCSS] 440: state & service refactor (#527)

* setup: get branch caught up and ready for work

* feat: refactored repository service and test

* feat: refactor of user service and test

* feat: updated user service spec

* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls

* attempt to fix issues with service updates; some refactoring and adjusting so app compiles

* feat: added auth user data to auth state; updated nav component to use auth state

* feat: adjusted auth call; fixed user call so home page loads

* moved some user logic; still having reload issues and repo view issues

* feat: got app working again! cleaned out console logs

* rebased and fixed most files

* fix broken tests

* removed unused code

* fix: fix pr comments and most tests

* fix: fixed final broken unit test

* fix: updated test; removed unused code in user effect; new user mapping file

* add todo for refactor improvements; update authUser effect to use different rxjs operation

Co-authored-by: LindaT <[email protected]>

* feat(solidjs) - Create navigation header (#840)

* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)

* fix(angular-apollo-tailwind): append protocol if missing from user url

Refs: #591

* test(angular-apollo-tailwind): update with testcases

Closes: #591

* chore: repo card with story and test (#737)

* chore: repo card with story and test

* fix comments

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore: gist panel UI (#741)

* chore: gist panel UI

* fix coment

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* [solidjs-pod] : Create component for search input and filter sort buttons (#831)

* in progress

* in progress

* in progress, paused for now

* chore: search filter sort component

* fixed comments on icons

* [solidjs-tailwinf] Add user profile card (#830)

* [SolidJS-Tailwind] Implement authentication (#734)

* chore(solidjs): remove example components

* feat(solidjs): add signin page

* refactor(solidjs): improve auth setup

* feat(solidjs): pencil in auth flow

* feat(solidjs): add example github communication

* [Angular - NgRx - SCSS] 440: state & service refactor (#527)

* setup: get branch caught up and ready for work

* feat: refactored repository service and test

* feat: refactor of user service and test

* feat: updated user service spec

* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls

* attempt to fix issues with service updates; some refactoring and adjusting so app compiles

* feat: added auth user data to auth state; updated nav component to use auth state

* feat: adjusted auth call; fixed user call so home page loads

* moved some user logic; still having reload issues and repo view issues

* feat: got app working again! cleaned out console logs

* rebased and fixed most files

* fix broken tests

* removed unused code

* fix: fix pr comments and most tests

* fix: fixed final broken unit test

* fix: updated test; removed unused code in user effect; new user mapping file

* add todo for refactor improvements; update authUser effect to use different rxjs operation

Co-authored-by: LindaT <[email protected]>

* feat(solidjs) - Create navigation header (#840)

* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)

* fix(angular-apollo-tailwind): append protocol if missing from user url

Refs: #591

* test(angular-apollo-tailwind): update with testcases

Closes: #591

* chore: repo card with story and test (#737)

* chore: repo card with story and test

* fix comments

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore: gist panel UI (#741)

* chore: gist panel UI

* fix coment

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore(solidjs): remove example components

* fixed comments, clean ups

Co-authored-by: Linda Thompson <[email protected]>
Co-authored-by: LindaT <[email protected]>
Co-authored-by: Daian Scuarissi <[email protected]>
Co-authored-by: Oluwakorede Cole <[email protected]>
Co-authored-by: Jerry Hogan <[email protected]>
Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore: updated amplify.yml file (#729)

* chore: updated amplify.yml file

* changed pnpm to npm

* chore: workflow added (#745)

* chore: workflow added

* CI setup fixes and testing

* CI setup fixes and testing

* CI setup fixes and testing

* tried everything but doesn't work, i think we have to merge this

* ..updates

* ..updates

* ..updates

* added auth token

* added auth token

Co-authored-by: Linda Thompson <[email protected]>
Co-authored-by: LindaT <[email protected]>
Co-authored-by: Daian Scuarissi <[email protected]>
Co-authored-by: Oluwakorede Cole <[email protected]>
Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>
Co-authored-by: Maarten Bicknese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[solidjs-pod] 02 Setup CI
3 participants