Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solidjs-pod]: Get Gists from GitHub API #838

Merged
merged 19 commits into from
Nov 18, 2022
Merged

Conversation

hdJerry
Copy link
Contributor

@hdJerry hdJerry commented Nov 7, 2022

Get Gists from GitHub API

Background

We want to show the user a list of their gists.

closes #689

Acceptance

  • Get gists from GitHub API
  • For display on main page; data needed:
    • Name of gist
    • html_url

Notes

@hdJerry hdJerry self-assigned this Nov 7, 2022
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-838.dbm2zhgk5abrj.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-838.d3sqkonra6x7y9.amplifyapp.com

@hdJerry
Copy link
Contributor Author

hdJerry commented Nov 7, 2022

This ticket still requires the auth ticket to be closed so as to be completed due to the token required. Aside that everything is in place

SDaian
SDaian previously approved these changes Nov 7, 2022
Copy link
Contributor

@SDaian SDaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lindakatcodes and others added 15 commits November 17, 2022 15:54
* setup: get branch caught up and ready for work

* feat: refactored repository service and test

* feat: refactor of user service and test

* feat: updated user service spec

* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls

* attempt to fix issues with service updates; some refactoring and adjusting so app compiles

* feat: added auth user data to auth state; updated nav component to use auth state

* feat: adjusted auth call; fixed user call so home page loads

* moved some user logic; still having reload issues and repo view issues

* feat: got app working again! cleaned out console logs

* rebased and fixed most files

* fix broken tests

* removed unused code

* fix: fix pr comments and most tests

* fix: fixed final broken unit test

* fix: updated test; removed unused code in user effect; new user mapping file

* add todo for refactor improvements; update authUser effect to use different rxjs operation

Co-authored-by: LindaT <[email protected]>
#637)

* fix(angular-apollo-tailwind): append protocol if missing from user url

Refs: #591

* test(angular-apollo-tailwind): update with testcases

Closes: #591
* chore: repo card with story and test

* fix comments

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>
* chore: gist panel UI

* fix coment

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>
…tons (#831)

* in progress

* in progress

* in progress, paused for now

* chore: search filter sort component

* fixed comments on icons
* chore(solidjs): remove example components

* feat(solidjs): add signin page

* refactor(solidjs): improve auth setup

* feat(solidjs): pencil in auth flow

* feat(solidjs): add example github communication

* [Angular - NgRx - SCSS] 440: state & service refactor (#527)

* setup: get branch caught up and ready for work

* feat: refactored repository service and test

* feat: refactor of user service and test

* feat: updated user service spec

* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls

* attempt to fix issues with service updates; some refactoring and adjusting so app compiles

* feat: added auth user data to auth state; updated nav component to use auth state

* feat: adjusted auth call; fixed user call so home page loads

* moved some user logic; still having reload issues and repo view issues

* feat: got app working again! cleaned out console logs

* rebased and fixed most files

* fix broken tests

* removed unused code

* fix: fix pr comments and most tests

* fix: fixed final broken unit test

* fix: updated test; removed unused code in user effect; new user mapping file

* add todo for refactor improvements; update authUser effect to use different rxjs operation

Co-authored-by: LindaT <[email protected]>

* feat(solidjs) - Create navigation header (#840)

* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)

* fix(angular-apollo-tailwind): append protocol if missing from user url

Refs: #591

* test(angular-apollo-tailwind): update with testcases

Closes: #591

* chore: repo card with story and test (#737)

* chore: repo card with story and test

* fix comments

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore: gist panel UI (#741)

* chore: gist panel UI

* fix coment

* fix coment

Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>

* chore(solidjs): remove example components

* fixed comments, clean ups

Co-authored-by: Linda Thompson <[email protected]>
Co-authored-by: LindaT <[email protected]>
Co-authored-by: Daian Scuarissi <[email protected]>
Co-authored-by: Oluwakorede Cole <[email protected]>
Co-authored-by: Jerry Hogan <[email protected]>
Co-authored-by: Victor Chukwuebuka Umeh <[email protected]>
* chore: updated amplify.yml file

* changed pnpm to npm
* chore: workflow added

* CI setup fixes and testing

* CI setup fixes and testing

* CI setup fixes and testing

* tried everything but doesn't work, i think we have to merge this
@hdJerry hdJerry requested a review from SDaian November 17, 2022 14:59
vyktoremario
vyktoremario previously approved these changes Nov 17, 2022
@hdJerry hdJerry merged commit 14d3c69 into main Nov 18, 2022
@hdJerry hdJerry deleted the solidjs/get-gists-api branch November 18, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[solidjs-pod] 05 Get Gists from GitHub API
6 participants