Skip to content

Commit

Permalink
Synchronous docker compose (#1446)
Browse files Browse the repository at this point in the history
<!-- Specify linked issues and REMOVE THE UNUSED LINES -->

Seems more reliable, we're having build failure issues where docker fails to start.

<!--

Describe your PR for reviewers.
Don't forget to set correct labels (User Facing / Beta / Feature Flag)
If there is UI change please add a screen capture.
-->

<!-- UNCOMMENT THIS SECTION IF NEEDED
<a name="iroh-services-clients">[§](#iroh-services-clients)</a> IROH Services Clients
=====================================================================================

Put all informations that need to be communicated to IROH Services Clients.
Typically IROH-UI, ATS Integration, Orbital, etc...
 -->

<a name="qa">[§](#qa)</a> QA
============================

<!--
Describe the steps to test your PR.

1.
2.
3.

Or if no QA is needed keep it as is.
 -->
No QA is needed.

<!-- UNCOMMENT THIS SECTION IF NEEDED
<a name="ops">[§](#ops)</a> Ops
===============================

  Specify Ops related issues and documentation
- Config change needed: threatgrid/tenzin#
- Migration needed: threatgrid/tenzin#
- How to enable/disable that feature: (ex remove service from `bootstrap.cfg`, add scope to org)
-->

<!-- UNCOMMENT THIS SECTION IF NEEDED
<a name="documentation">[§](#documentation)</a> Documentation
=============================================================

  Public Facing documentation section;
- Public documentation updated needed: threatgrid/iroh-ui#
  See internal [doc file](./services/iroh-auth/doc/public-doc.org)
 -->

<a name="release-notes">[§](#release-notes)</a> Release Notes
=============================================================

<!-- REMOVE UNUSED LINES -->

```
intern: Synchronous docker compose
```

<a name="squashed-commits">[§](#squashed-commits)</a> Squashed Commits
======================================================================
  • Loading branch information
frenchy64 authored Oct 8, 2024
1 parent 90eea0d commit 592a2f5
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
- name: Upload current test timing
uses: actions/upload-artifact@v3
with:
retention-days: 30
retention-days: 180
name: current-test-timing
path: dev-resources/ctia_test_timings.edn

Expand Down Expand Up @@ -236,13 +236,9 @@ jobs:
- name: Install babashka
run: ./scripts/actions/install-bb.sh
- run: ./scripts/actions/setup_env.clj
# run docker as early as possible asynchronously. if this command
# fails, the split-test test runner will timeout in a reasonable amount
# of time and throw an error. See `Upload docker compose` step below
# for retrieving this log after a build.
- name: Docker (async)
- name: Docker
# depends on LOG_PATH and actions/checkout@v3
run: docker compose -f containers/dev/docker-compose.yml up -d &> "${LOG_PATH}/docker-compose.log" &
run: docker compose -f containers/dev/docker-compose.yml up --no-color -d &> "${LOG_PATH}/docker-compose.log"
- name: Download test timings
uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -370,7 +366,7 @@ jobs:
- name: Upload all test timings
uses: actions/upload-artifact@v3
with:
retention-days: 60
retention-days: 180
name: all-test-timings
path: target/test-results/*.edn

Expand Down

0 comments on commit 592a2f5

Please sign in to comment.