-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronous docker compose #1446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchy64
requested review from
gbuisson,
yogsototh,
msprunck,
ereteog,
turbodog99,
wandersoncferreira,
DeLaGuardo,
obarbeau,
marioaquino,
safi,
t2sw and
brookeswanson
as code owners
October 8, 2024 18:38
pat-patat
approved these changes
Oct 8, 2024
yogsototh
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pawanbahuguna
pushed a commit
that referenced
this pull request
Oct 9, 2024
<!-- Specify linked issues and REMOVE THE UNUSED LINES --> Seems more reliable, we're having build failure issues where docker fails to start. <!-- Describe your PR for reviewers. Don't forget to set correct labels (User Facing / Beta / Feature Flag) If there is UI change please add a screen capture. --> <!-- UNCOMMENT THIS SECTION IF NEEDED <a name="iroh-services-clients">[§](#iroh-services-clients)</a> IROH Services Clients ===================================================================================== Put all informations that need to be communicated to IROH Services Clients. Typically IROH-UI, ATS Integration, Orbital, etc... --> <a name="qa">[§](#qa)</a> QA ============================ <!-- Describe the steps to test your PR. 1. 2. 3. Or if no QA is needed keep it as is. --> No QA is needed. <!-- UNCOMMENT THIS SECTION IF NEEDED <a name="ops">[§](#ops)</a> Ops =============================== Specify Ops related issues and documentation - Config change needed: threatgrid/tenzin# - Migration needed: threatgrid/tenzin# - How to enable/disable that feature: (ex remove service from `bootstrap.cfg`, add scope to org) --> <!-- UNCOMMENT THIS SECTION IF NEEDED <a name="documentation">[§](#documentation)</a> Documentation ============================================================= Public Facing documentation section; - Public documentation updated needed: threatgrid/iroh-ui# See internal [doc file](./services/iroh-auth/doc/public-doc.org) --> <a name="release-notes">[§](#release-notes)</a> Release Notes ============================================================= <!-- REMOVE UNUSED LINES --> ``` intern: Synchronous docker compose ``` <a name="squashed-commits">[§](#squashed-commits)</a> Squashed Commits ======================================================================
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems more reliable, we're having build failure issues where docker fails to start.
§ QA
No QA is needed.
§ Release Notes
§ Squashed Commits