Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous docker compose #1446

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Synchronous docker compose #1446

merged 8 commits into from
Oct 8, 2024

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Oct 8, 2024

Seems more reliable, we're having build failure issues where docker fails to start.

§ QA

No QA is needed.

§ Release Notes

intern: Synchronous docker compose

§ Squashed Commits

@frenchy64 frenchy64 changed the title debug build Synchronous docker compose Oct 8, 2024
@frenchy64 frenchy64 marked this pull request as ready for review October 8, 2024 18:38
@frenchy64 frenchy64 self-assigned this Oct 8, 2024
Copy link
Contributor

@yogsototh yogsototh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frenchy64 frenchy64 merged commit 592a2f5 into master Oct 8, 2024
14 checks passed
pawanbahuguna pushed a commit that referenced this pull request Oct 9, 2024
<!-- Specify linked issues and REMOVE THE UNUSED LINES -->

Seems more reliable, we're having build failure issues where docker fails to start.

<!--

Describe your PR for reviewers.
Don't forget to set correct labels (User Facing / Beta / Feature Flag)
If there is UI change please add a screen capture.
-->

<!-- UNCOMMENT THIS SECTION IF NEEDED
<a name="iroh-services-clients">[§](#iroh-services-clients)</a> IROH Services Clients
=====================================================================================

Put all informations that need to be communicated to IROH Services Clients.
Typically IROH-UI, ATS Integration, Orbital, etc...
 -->

<a name="qa">[§](#qa)</a> QA
============================

<!--
Describe the steps to test your PR.

1.
2.
3.

Or if no QA is needed keep it as is.
 -->
No QA is needed.

<!-- UNCOMMENT THIS SECTION IF NEEDED
<a name="ops">[§](#ops)</a> Ops
===============================

  Specify Ops related issues and documentation
- Config change needed: threatgrid/tenzin#
- Migration needed: threatgrid/tenzin#
- How to enable/disable that feature: (ex remove service from `bootstrap.cfg`, add scope to org)
-->

<!-- UNCOMMENT THIS SECTION IF NEEDED
<a name="documentation">[§](#documentation)</a> Documentation
=============================================================

  Public Facing documentation section;
- Public documentation updated needed: threatgrid/iroh-ui#
  See internal [doc file](./services/iroh-auth/doc/public-doc.org)
 -->

<a name="release-notes">[§](#release-notes)</a> Release Notes
=============================================================

<!-- REMOVE UNUSED LINES -->

```
intern: Synchronous docker compose
```

<a name="squashed-commits">[§](#squashed-commits)</a> Squashed Commits
======================================================================
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants