Feat: Node finder enhance Rentable toggle
#3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0oM4R
changed the title
Rentable toggleNode finder enhance Rentable toggle
0oM4R
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
mohamedamer453 and
samaradel
as code owners
amiraabouhadid
approved these changes
Jul 7, 2024
samaradel
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rentable sounds like that we will list to go rentable nodes, the old behavior was listing all rentable nodes; but the user can't rent a
downnode.so we introduce new flow for this toggle:
toggling on the rentable filter setting the value of node status filter to
Up & Rentabletoggling off the renatable filter will revert the previous value
Changes
Add watcher on rentable filter, and if it is selected, and the status field is empty will update the status to be up and standby
Screencast.from.04.2024.EEST.02.23.42.webm
Related Issues
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist