shim/rollkit: downgrade proto/upgrade rollkit #258
Comments
pepyakin
added a commit
that referenced
this issue
Feb 26, 2024
This changeset migrates the rollkit demo to go-da, the more modern version of the DA interface for Rollkit. One of the most important changes is that rollkit doesn't embed the adapters anymore. Instead, it communicates with the adapter through gRPC protocol. Instead of yet another adapter, this implements gRPC dock directly, which kind of challenges the current architecture. Notable changes: 1. demo/rollkit was regenerated from the tutorial once again. That turned out to be easier than manually porting changes. I ported init-local.sh though. 2. removed adapter/sugondat since it is not longer needed 3. since it looks like we are going away from the docker workflow, I did not port the Dockerfile to the new code. I left the docker-compose.yml though, just removed the gm service. 4. the JSON-RPC was pushed to the sovereign dock. Now `serve` subcommand will launch only the specified dock instead of all of them. Each dock has its own subcommand. `ikura-shim serve rollkit` is now used for running rollkit. 5. now dock subcommands get their own options. E.g. rollkit doc now can accept the default namespace in case requests from rollkit without namespace (they do atm). There are some things that were left for follow ups: 1. #258 1. #259
pepyakin
added a commit
that referenced
this issue
Feb 26, 2024
This changeset migrates the rollkit demo to go-da, the more modern version of the DA interface for Rollkit. One of the most important changes is that rollkit doesn't embed the adapters anymore. Instead, it communicates with the adapter through gRPC protocol. Instead of yet another adapter, this implements gRPC dock directly, which kind of challenges the current architecture. Notable changes: 1. demo/rollkit was regenerated from the tutorial once again. That turned out to be easier than manually porting changes. I ported init-local.sh though. 2. removed adapter/sugondat since it is not longer needed 3. since it looks like we are going away from the docker workflow, I did not port the Dockerfile to the new code. I left the docker-compose.yml though, just removed the gm service. 4. the JSON-RPC was pushed to the sovereign dock. Now `serve` subcommand will launch only the specified dock instead of all of them. Each dock has its own subcommand. `ikura-shim serve rollkit` is now used for running rollkit. 5. now dock subcommands get their own options. E.g. rollkit doc now can accept the default namespace in case requests from rollkit without namespace (they do atm). There are some things that were left for follow ups: 1. #258 1. #259
pepyakin
added a commit
that referenced
this issue
Feb 27, 2024
This changeset migrates the rollkit demo to go-da, the more modern version of the DA interface for Rollkit. One of the most important changes is that rollkit doesn't embed the adapters anymore. Instead, it communicates with the adapter through gRPC protocol. Instead of yet another adapter, this implements gRPC dock directly, which kind of challenges the current architecture. Notable changes: 1. demo/rollkit was regenerated from the tutorial once again. That turned out to be easier than manually porting changes. I ported init-local.sh though. 2. removed adapter/sugondat since it is not longer needed 3. since it looks like we are going away from the docker workflow, I did not port the Dockerfile to the new code. I left the docker-compose.yml though, just removed the gm service. 4. the JSON-RPC was pushed to the sovereign dock. Now `serve` subcommand will launch only the specified dock instead of all of them. Each dock has its own subcommand. `ikura-shim serve rollkit` is now used for running rollkit. 5. now dock subcommands get their own options. E.g. rollkit doc now can accept the default namespace in case requests from rollkit without namespace (they do atm). There are some things that were left for follow ups: 1. #258 1. #259
pepyakin
added a commit
that referenced
this issue
Feb 28, 2024
This changeset migrates the rollkit demo to go-da, the more modern version of the DA interface for Rollkit. One of the most important changes is that rollkit doesn't embed the adapters anymore. Instead, it communicates with the adapter through gRPC protocol. Instead of yet another adapter, this implements gRPC dock directly, which kind of challenges the current architecture. Notable changes: 1. demo/rollkit was regenerated from the tutorial once again. That turned out to be easier than manually porting changes. I ported init-local.sh though. 2. removed adapter/sugondat since it is not longer needed 3. since it looks like we are going away from the docker workflow, I did not port the Dockerfile to the new code. I left the docker-compose.yml though, just removed the gm service. 4. the JSON-RPC was pushed to the sovereign dock. Now `serve` subcommand will launch only the specified dock instead of all of them. Each dock has its own subcommand. `ikura-shim serve rollkit` is now used for running rollkit. 5. now dock subcommands get their own options. E.g. rollkit doc now can accept the default namespace in case requests from rollkit without namespace (they do atm). There are some things that were left for follow ups: 1. #258 1. #259
pepyakin
added a commit
that referenced
this issue
Mar 4, 2024
the version that was introduced in #260 (997046d) was using the latest version of go-da (0.4.0). However, the latest version of rollkit on which the gm demo was based off, was using 0.2.0. That was causing occasional problems. So I went ahead and downgraded it. Now, it seems to workfine (with exception of #259). Closes #258.
pepyakin
added a commit
that referenced
this issue
Mar 4, 2024
the version that was introduced in #260 (997046d) was using the latest version of go-da (0.4.0) gRPC service decl. However, the latest version of rollkit on which the gm demo was based off, was using 0.2.0. That was causing occasional problems. So I went ahead and downgraded it. Now, it seems to workfine (with exception of #259). Closes #258.
pepyakin
added a commit
that referenced
this issue
Mar 5, 2024
the version that was introduced in #260 (997046d) was using the latest version of go-da (0.4.0) gRPC service decl. However, the latest version of rollkit on which the gm demo was based off, was using 0.2.0. That was causing occasional problems. So I went ahead and downgraded it. Now, it seems to workfine (with exception of #259). Closes #258.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
it seems that rollkit that we are using uses go-da 0.2.0. However, the proto for gRPC service is taken from 0.4.0. This still works but sometimes it does crash.
We should either downgrade the proto of go-da to 0.2 or wait until rollkit releases version that depends on go-da 0.4.0.
The text was updated successfully, but these errors were encountered: