shim/rollkit: downgrade go-da to 0.2.0 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
the version that was introduced in #260 (997046d) was using the latest version of go-da (0.4.0) gRPC service decl. However, the latest version of rollkit on which the gm demo was based off, was using 0.2.0. That was causing occasional problems. So I went ahead and downgraded it. Now, it seems to workfine (with exception of #259). Closes #258.
pepyakin
force-pushed
the
pep-rollkit-downgrade-goda
branch
from
417ed72
to
f6d7847
Compare
gabriele-0201
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the version that was introduced in #260
(997046d) was using
the latest version of go-da (0.4.0) gRPC service decl.
However, the latest version of rollkit on which the gm
demo was based off, was using 0.2.0. That was causing
occasional problems.
So I went ahead and downgraded it. Now, it seems to
workfine (with exception of #259).
Closes #258.