Add "Sign in with Google" button #6096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flow is not a great user experience. But it's the fastest way I could think of to add the button that was requested by Google.
|
For reference: Google's Sign-In Branding Guidelines |
|
I suspect this is obvious, but I think it's very important that unless the user chooses to do something that requires interacting with google (like adding an account at gmail), then nothing googly should appear on the screen or in network traffic. From context, it seems that this pops up only after entering a gmail address and hitting next -- and that seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flow is not a great user experience. But it's the fastest way I could think of to add the button that was requested by Google.