[TIMOB-20320]: Refactor requestPermissions

[hieupham007]

JIRA: https://jira.appcelerator.org/browse/TIMOB-20320

[ashcoding]

Would this cause any memory leaks on Activities (Windows)? Might need to check when using this, when the Window is closed, does the Activity get released by doing Heap dumps.

[ashcoding]

I did a check and there was no leak on WindowProxy by opening 10 windows and requesting (and denying) permissions using the code below:-

(function openWindow(n) {
    var win = Ti.UI.createWindow({
        backgroundColor : "#aaaaaa",
        layout : "vertical"
    });

    win.title = "Window # " + n;

    var label = Ti.UI.createLabel({
        text : "Window # " + n,
        color : "#ffffff",
        top : 20
    });

    win.add(label);
    label = null;

    var openButton = Ti.UI.createButton({
        title : "Open",
        color : "#ffffff",
        top : 20,
        _n: n
    });

    openButton.addEventListener('click', function onOpenByButton(evt) {
        openWindow(evt.source._n + 1);
    });

    win.add(openButton);
    openButton = null;

    var closeButton = Ti.UI.createButton({
        title : "Close",
        color : "#ffffff",
        top : 20
    });

    closeButton.addEventListener('click', function onCloseByButton(evt) {
        evt.source.getParent().close();
    });

    win.add(closeButton);

    win.open();
    Ti.Media.requestCameraPermissions(function(e) {
        if (e.success === true) {
                Ti.API.log("Success");
            } else {
                Ti.API.log("Access denied, error: " + e.error);
            }
    });
    win = null;
})(1);

Code is based on https://jira.appcelerator.org/browse/TIMOB-19891.

No leaks seen when hprof was inspected for WindowProxy.

[ashcoding]

Everything looks good and seems to be working but would help greatly if there was a test app.js provided to test all the permissions.

[ashcoding]

Functionally tested with code from jira:-

var cameraPermission = "android.permission.CAMERA";
var storagePermission = "android.permission.READ_EXTERNAL_STORAGE";
var hasCameraPerm = Ti.Android.hasPermission(cameraPermission);
var hasStoragePerm = Ti.Android.hasPermission(storagePermission);
var permissionsToRequest = [];
if (!hasCameraPerm) {
    permissionsToRequest.push(cameraPermission);
}
if (!hasStoragePerm) {
    permissionsToRequest.push(storagePermission);
}
if (permissionsToRequest.length > 0) {
    Ti.Android.requestPermissions(permissionsToRequest, function(e) {
        if (e.success) {
            Ti.API.info("SUCCESS");
        } else {
            Ti.API.info("ERROR: " + e.error);
        }
    });
}

Code reviewed and functionally tested to be working well. 👍
Approved

[ashcoding]

@jonasbjurhult Thanks for your comment! Could you show an example code of what you mean?