Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more double vars_select() 🚫 #296

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Conversation

juliasilge
Copy link
Member

Before this PR, tidyselect::vars_select() was called twice inside of initial_split(). This generated messages like:

"Message"
"  Note: Using an external vector in selections is ambiguous."
"  i Use `all_of(group)` instead of `group` to silence this message."
"  i See <https://tidyselect.r-lib.org/reference/faq-external-vector.html>."
"  This message is displayed once per session."

We don't need to vars_select() twice, and instead can pass strata as {{ strata }}. Closes #294

@juliasilge
Copy link
Member Author

This does in fact remove the message from the GH action runs ⬆️

@juliasilge juliasilge merged commit d78f5a2 into main Jun 10, 2022
@juliasilge juliasilge deleted the no-more-double-vars-select branch June 10, 2022 22:05
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note: Using an external vector in selections is ambiguous.
1 participant