Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass group and strata as curly #57

Merged
merged 2 commits into from
Jun 12, 2022
Merged

Pass group and strata as curly #57

merged 2 commits into from
Jun 12, 2022

Conversation

mikemahoney218
Copy link
Member

@mikemahoney218 mikemahoney218 commented Jun 11, 2022

Inspired by Julia's sleuthing here: tidymodels/rsample#296 , I believe this lets us take away the suppressMessage calls we had in tests by not trying to evaluate group or strata twice.

@mikemahoney218 mikemahoney218 changed the title Pass group as curly Pass group and strata as curly Jun 11, 2022
@mikemahoney218 mikemahoney218 marked this pull request as ready for review June 12, 2022 20:27
Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌

@juliasilge juliasilge merged commit eba3264 into main Jun 12, 2022
@juliasilge juliasilge deleted the mike/curlier branch June 12, 2022 21:55
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants