Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 3.2.0 need to mention possible failures of downstream visual tests #3304

Closed
clauswilke opened this issue May 6, 2019 · 5 comments
Milestone

Comments

@clauswilke
Copy link
Member

See: #3303 (comment)

There have been subtle changes to text rendering, and this may cause vdiffr changes in downstream packages. The release notes should state that.

@clauswilke clauswilke added this to the ggplot2 3.2.0 milestone May 6, 2019
@yutannihilation
Copy link
Member

#3050 also introduces visual changes.

@clauswilke
Copy link
Member Author

@paleolimbot Could you contact the authors of the packages who will have to update their vdiffr reference images?

@paleolimbot
Copy link
Member

Done!

@xrobin
Copy link

xrobin commented May 15, 2019

Thanks for the heads up! Do you already have a planned release date for this version?

I assume for the CI tests (travis/appveyor) it's going to be difficult to update the reference images before the CRAN release, so having some idea of when to expect the release would help.

@lock
Copy link

lock bot commented Nov 11, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants