Improved release notes #3324
Improved release notes #3324
Conversation
NEWS.md
Outdated
| @@ -7,6 +7,12 @@ extension developers if they have relied on internals that have been changed. | |||
| This release also sees the addition of Hiroaki Yutani (@yutannihilation) to the | |||
| core developer team. | |||
|
|
|||
| Two patches (#2996 and #3050) fixed minor rendering problems. In most cases, the | |||
There was a problem hiding this comment.
Maybe put under ## Breaking changes?
There was a problem hiding this comment.
That works for me. I remember we had some discussion in the past about what exactly a breaking change is, but it feels like a breaking change to me. I also added a bullet point where I'm trying to express that ggplot2 is now somewhat stricter and now creates errors or warnings where previously it would just create some arbitrary output. Not sure I'm totally happy with the wording. I'm referring to issues such as #3316, #3305, #3318.
There was a problem hiding this comment.
I added the specific examples to the bullet point. I think that makes it better.
There was a problem hiding this comment.
I'd say that breaking a revdep check is sufficient (but not necessary) for a change to be breaking.
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 171 171
Lines 6692 6692
=======================================
Hits 5283 5283
Misses 1409 1409Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 171 171
Lines 6692 6692
=======================================
Hits 5283 5283
Misses 1409 1409Continue to review full report at Codecov.
|
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
I added a paragraph about visual changes to the release notes, as discussed in #3304.
@hadley @batpigandme Could you review? I wasn't entirely sure where to place the paragraph, but I feel it should be up on top so people see it even if they don't read through the entire set of notes.