-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to scales::Range classes #5086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'm not fully sure if there's no package that expects a range object is a ggproto, so let me keep this unmerged for a while.
Yeah good point. It seems like a good idea to search github for the use of |
Moreover, this move would be a little bit too risky for an upcoming patch release, so I think it'd be best to wait for after that has happened. I'll convert this to a draft until that happens, so it isn't accidentally merged. |
I agree with you. Thanks, let's wait. |
Hi @yutannihilation, with ggplot2 3.4.1 having landed on CRAN, do you think this is OK to merge now? |
Oh, thanks for the notice. I think so, but maybe we can merge #5171 first? We'll anyway need to resolve conflict on NEWS.md there, so I think either is fine. |
Now that #5171 got merged, let's merge this. |
Thanks Hiroaki! |
This PR aims to fix #2710.
In brief, it replaces the unexported Range ggproto classes with the scales::Range R6 classes. This makes it slightly easier for extension developers to use the Range systems. Extenders have been able to do this for a while, but hopefully this serves as an 'endorsement' of using scales' Range classes.