-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release ggplot2 3.4.1 #5171
Release ggplot2 3.4.1 #5171
Conversation
Would you like me to resolve the NEWS.md conflict by harmonising the news? I'm not sure what the implications of that are if we're releasing from the RC branch, i.e. does the future CRAN version get an awkward news section? |
No, we shouldn't resolve anything at this point. We do that after release before merging in the rc branch. If we did it now the news in the release would not reflect the actual release |
comment = c(ORCID = "0000-0003-4757-117X")), | ||
person("Winston", "Chang", role = "aut", | ||
comment = c(ORCID = "0000-0002-1576-2126")), | ||
person("Lionel", "Henry", role = "aut"), | ||
person("Thomas Lin", "Pedersen", , "thomas.pedersen@rstudio.com", role = c("aut", "cre"), | ||
person("Thomas Lin", "Pedersen", , "thomas.pedersen@posit.co", role = c("aut", "cre"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to update the RStudio line at the bottom of the authors to "Posit Software, PBC"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to wait for spring cleaning with this as it was already submitted
@thomasp85 |
Yes, I'm back from vacation next week so will do it then |
I see, I'll wait for it, thanks. |
Fix #5149