fix(ndt_scan_matcher): delete diagnostics thread (#5532) #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5532) Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
YamatoAndo
requested review from
KYabuuchi,
kminoda and
Motsu-san
as code owners
TakaHoribe
approved these changes
Nov 9, 2023
|
same PR was merged in AWF: autowarefoundation#5532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a result of verification, the following error occurred within the timer_diagnostics function, causing the node to crash.
Therefore, to make it thread-safe, we decided to remove the thread processing.
Furthermore, to ensure thread safety, I've made sure that functions other than callback_sensor_points do not access
state_ptr_.Related links
N/A
Tests performed
LSim works.
Notes for reviewers
We plan to make significant improvements to the diagnostics of the ndt_scan_matcher in the near future.
autowarefoundation#5076
Interface changes
N/A
Effects on system behavior
N/A
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.