fix(raw_vehicle_cmd_converter): fix parameter files to parse path to csv files (#6136) #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…csv files (autowarefoundation#6136) Signed-off-by: Fumiya Watanabe <[email protected]>
h-ohta
requested review from
mkuri,
taikitanaka3,
TakaHoribe and
yukkysaito
as code owners
0x126
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
I checked https://tier4.atlassian.net/browse/RT0-30609?focusedCommentId=155746
LGTM !
|
@Mergifyio backport beta/v0.19.2 |
❌ No backport have been created
GitHub error: |
|
@Mergifyio backport beta/v0.19.2 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…csv files (autowarefoundation#6136) (#1139) Signed-off-by: Fumiya Watanabe <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> (cherry picked from commit 604848f)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport from autowarefoundation#6136
Related links
https://tier4.atlassian.net/browse/RT0-30609
Tests performed
I confirmed in https://tier4.atlassian.net/browse/RT0-30609?focusedCommentId=155746
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.