feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468) #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." Signed-off-by: Tomohito Ando <[email protected]> * add comments for clarity Signed-off-by: Tomohito Ando <[email protected]> * fix comments for clarity Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
requested review from
satoshi-ota,
shmpwk,
tkimura4,
rej55,
isamu-takagi,
soblin,
kosuke55,
kyoichi-sugahara,
mkuri,
maxime-clem,
taikitanaka3 and
takayuki5168
as code owners
TomohitoAndo
requested review from
0x126 and
saka1-s
and removed request for
mkuri,
rej55,
takayuki5168,
soblin,
kyoichi-sugahara,
kosuke55,
shmpwk,
isamu-takagi,
satoshi-ota,
tkimura4,
taikitanaka3 and
maxime-clem
TomohitoAndo
changed the title
TomohitoAndo
added a commit
that referenced
this pull request
Apr 11, 2024
…nce received, is not received again (autowarefoundation#6468) (#1156) feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468) * feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again." * add comments for clarity * fix comments for clarity --------- Signed-off-by: Tomohito Ando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick this PR.
Now, if a signal message is received but a subsequent traffic signal message is not, the ego vehicle will stop.
Tests performed
See autowarefoundation#6468
I also conducted tests on beta/v0.19.1
simplescreenrecorder-2024-02-26_15.57.00.mp4
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.