Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix lv4 bicycle pedestrian prediction issue #1191

Merged

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Mar 14, 2024

Description

自転車の挙動に関するPRです。

  • tracker挙動改善
    • 歩行者自転車の追従性能向上
    • Unknown検知を歩行者自転車のTrackletへと対応付け可能にする(デグレ注意)
  • predictionによる走行レーン内歩行者のPath算出方法の変更
    https://tier4.atlassian.net/browse/RT0-30816

Related links

  • tickets
  1. https://tier4.atlassian.net/browse/RT0-30816 ✔️
  2. https://tier4.atlassian.net/browse/RT0-30812 ✔️

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

YoshiRi and others added 2 commits March 14, 2024 17:59
fix(multi_object_tracking): mot bicycle model revision, tracking_object_merger bugfix
…ocess (autowarefoundation#6607)

* feat: object class filter

Signed-off-by: Taekjin LEE <[email protected]>

* fix: set a member private

Signed-off-by: Taekjin LEE <[email protected]>

* fix: last filtered label is not useful, remove

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: multiply gain for new class

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: algorithm explanation

Signed-off-by: Taekjin LEE <[email protected]>

* fix: revise the filtering process flow

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@TomohitoAndo TomohitoAndo changed the title Feat/fix lv4 bicicle pedestrian prediction issue Feat/fix lv4 bicycle pedestrian prediction issue Mar 27, 2024
@YoshiRi YoshiRi marked this pull request as ready for review March 28, 2024 02:51
@0x126 0x126 changed the title Feat/fix lv4 bicycle pedestrian prediction issue chore: fix lv4 bicycle pedestrian prediction issue Mar 28, 2024
@0x126 0x126 changed the title chore: fix lv4 bicycle pedestrian prediction issue feat: fix lv4 bicycle pedestrian prediction issue Mar 28, 2024
@TomohitoAndo
Copy link

TomohitoAndo commented Mar 28, 2024

I confirmed there are no obvious degradation.

Please refer to the details at the following link:
TIER IV INTERNAL

@TomohitoAndo TomohitoAndo merged commit c5066a0 into beta/v0.19.1 Mar 29, 2024
20 of 29 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/fix_lv4_bicicle_pedestrian_prediction_issue branch March 29, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants