Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trajecotry_follower,trajecotry_follower_nodes): add constant acc #149

Conversation

taikitanaka3
Copy link

@taikitanaka3 taikitanaka3 commented Oct 13, 2022

Description

  • add contant velocity controller for psim testing

Related links

experiment-2022-10-20_19.43.46.mp4

Tests performed

by psim

because psim doesn't have any limitation for velocity or acceleration this will keeps accelerating
https://user-images.githubusercontent.com/65527974/195523927-aff283ed-2659-43cb-991b-3c69839a796b.mp4

Notes for reviewers

Dont merge this

this PR needs this change and set option constant
tier4/autoware_launch#514

    # longitudinal controller mode
    add_launch_arg(
        "longitudinal_controller_mode",
        "constant",
        "longitudinal controller mode: `pid` or `constant`",
    )

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.5.3@aee2610). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.5.3     #149   +/-   ##
==============================================
  Coverage               ?   42.29%           
==============================================
  Files                  ?       54           
  Lines                  ?     3769           
  Branches               ?     1918           
==============================================
  Hits                   ?     1594           
  Misses                 ?      679           
  Partials               ?     1496           
Flag Coverage Δ
differential 42.23% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taikitanaka3 taikitanaka3 changed the title feat(trajecotry_follower,trajecotry_follower_nodes): add constant vel… feat(trajecotry_follower,trajecotry_follower_nodes): add constant acc Oct 14, 2022
@taikitanaka3 taikitanaka3 deleted the beta/v0.5.3_feature_contant_velocity_controller branch November 24, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants