-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rtc_reaplyer): add rtc_replayer (#1993) #178
Conversation
* feat(rtc_replayer): add rtc_reaplayer Signed-off-by: tanaka3 <[email protected]> * chore: small fix Signed-off-by: tanaka3 <[email protected]> * doc: update Signed-off-by: taikitanaka3 <[email protected]> * chore: add debug print Signed-off-by: tanaka3 <[email protected]> * fix: fix * fix: build fail * style: spell check Signed-off-by: tanaka3 <[email protected]> Signed-off-by: tanaka3 <[email protected]> Signed-off-by: taikitanaka3 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## beta/v0.5.2-odaiba3 #178 +/- ##
=====================================================
Coverage ? 0.00%
=====================================================
Files ? 1
Lines ? 51
Branches ? 0
=====================================================
Hits ? 0
Misses ? 51
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Let me confirm to make sure that this PR is only for beta/v0.5.2-odaiba3 ? |
@shmpwk |
Ok, I found this, thank you. I understand this is cherry-pick commit. |
<arg name="param_path" default="$(find-pkg-share rtc_auto_mode_manager)/config/rtc_auto_mode_manager.param.yaml"/> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this param file does not seem to exist in odaiba3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was added with autowarefoundation#1541 to main
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: taikitanaka3 [email protected]
Description
this can be merged if there is no build error
this will be added to debug tool
https://github.com/tier4/debug_tools/blob/ad465ef3d3e082e6a2bf42165fa6a03f4d7b4c61/analyze_without_planning.tmux#L66
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.