Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick for ground segmentation #329

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

0x126
Copy link

@0x126 0x126 commented Mar 20, 2023

Description

  • cherry-pick for ground_segmentation

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

badai-nguyen and others added 2 commits March 20, 2023 10:12
…ndation#2448)

* fix: reclassify ground cluster pcl

Signed-off-by: badai-nguyen <[email protected]>

* fix: add lowest-based recheck

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactoring

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactoring

Signed-off-by: badai-nguyen <[email protected]>

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
@0x126 0x126 requested a review from TomohitoAndo March 20, 2023 01:15
@github-actions github-actions bot added documentation Improvements or additions to documentation perception labels Mar 20, 2023
@0x126 0x126 changed the title Chore/cherry pick/ground segmentation chore: cherry pick for ground segmentation Mar 20, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.6.1@c619db5). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.6.1     #329   +/-   ##
==============================================
  Coverage               ?   10.58%           
==============================================
  Files                  ?     1247           
  Lines                  ?    90032           
  Branches               ?    20803           
==============================================
  Hits                   ?     9532           
  Misses                 ?    70413           
  Partials               ?    10087           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.56% <0.00%> (?) Carriedforward from 56f9be9

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x126 0x126 merged commit 687c348 into beta/v0.6.1 Mar 20, 2023
@0x126 0x126 deleted the chore/cherry-pick/ground_segmentation branch March 20, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation perception
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants