Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accel_brake_map_calibrator): add COLCON_IGNORE #436

Merged
merged 2 commits into from
May 12, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 12, 2023

Description

tier4_calibration_rviz_pluginでのみ使用されているが、そのパッケージはIGNOREしているため、このパッケージにもCOLCON_IGNOREを付与

Related Llinks

https://tier4.atlassian.net/browse/AEAP-485

Tests performed

$ cd ~/pilot-auto.x1.eve/src/
$ grep . -r -e accel_brake_map_calibrator --exclude-dir .git -l

にてlauncher側で参照されていないことを確認

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

検索wordが引っかかったlaunchファイルは、IGNOREファイル配下のため問題なし。
./autoware/universe/vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/launch/accel_brake_map_calibrator.launch.xml

@h-ohta h-ohta merged commit 990502c into beta/v0.3.16 May 12, 2023
@h-ohta h-ohta deleted the h-ohta-patch-1 branch May 12, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants