Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): improve avoidance stop & decel behavior (#4141) #651

Merged

Conversation

satoshi-ota
Copy link

@satoshi-ota satoshi-ota commented Jul 7, 2023

  • feat(path_shifter): add utils

  • feat(avoidance): shorten avoidance stop distance

  • feat(avoidance): insert slow down speed

  • fix(avoidance): don't set stoppable=true for objects that ego doesn't have to avoid

  • refactor(avoidance): rename unreadable variable name

  • docs(avoidance): add new parameter description


Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ndation#4141)

* feat(path_shifter): add utils

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): shorten avoidance stop distance

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): insert slow down speed

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): don't set stoppable=true for objects that ego doesn't have to avoid

Signed-off-by: satoshi-ota <[email protected]>

* refactor(avoidance): rename unreadable variable name

Signed-off-by: satoshi-ota <[email protected]>

* docs(avoidance): add new parameter description

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi 1222-takeshi merged commit 8444898 into tier4:beta/v0.8.1-odaiba1 Jul 7, 2023
@satoshi-ota satoshi-ota deleted the hotfix/avoidance branch July 7, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants