Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosswalk): fix build #801

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Sep 5, 2023

Description

fix cherry-pick mistakes of eb13433

build failed in
https://evaluation.tier4.jp/evaluation/reports/39b89374-45b2-5c16-b180-58e9ddfed30f?project_id=prd_jt

/home/autoware/autoware.proj/src/autoware/universe/planning/behavior_velocity_crosswalk_module/src/scene_crosswalk.cpp: In member function ‘tier4_autoware_utils::Polygon2d behavior_velocity_planner::CrosswalkModule::getAttentionArea(const PathWithLaneId&, const std::pair<double, double>&) const’:
/home/autoware/autoware.proj/src/autoware/universe/planning/behavior_velocity_crosswalk_module/src/scene_crosswalk.cpp:750:60: error: ‘p_ego_front’ was not declared in this scope
  750 |     const auto ego_one_step_polygon = createOneStepPolygon(p_ego_front, p_ego_back, ego_polygon);
      |                                                            ^~~~~~~~~~~
/home/autoware/autoware.proj/src/autoware/universe/planning/behavior_velocity_crosswalk_module/src/scene_crosswalk.cpp:750:73: error: ‘p_ego_back’ was not declared in this scope
  750 |     const auto ego_one_step_polygon = createOneStepPolygon(p_ego_front, p_ego_back, ego_polygon);
      |                                                                         ^~~~~~~~~~
gmake[2]: *** [CMakeFiles/behavior_velocity_crosswalk_module.dir/build.make:104: CMakeFiles/behavior_velocity_crosswalk_module.dir/src/scene_crosswalk.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:137: CMakeFiles/behavior_velocity_crosswalk_module.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< behavior_velocity_crosswalk_module [8min 8s, exited with code 2]

Tests performed

build in my local

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Author

kosuke55 commented Sep 5, 2023

https://evaluation.tier4.jp/evaluation/reports/325d2014-4984-5b60-bbd6-59d8af82591c?project_id=prd_jt

@tkimura4
Copy link
Collaborator

tkimura4 commented Sep 5, 2023

Thank you!!!

@tkimura4 tkimura4 merged commit d992f4d into beta/v0.10.0 Sep 5, 2023
18 checks passed
@tkimura4 tkimura4 deleted the fix/beta/v0.10.0/crosswalk-build branch September 5, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants