Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection)!: disable the exception behavior in the private areas #921

Closed
wants to merge 1 commit into from

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Oct 6, 2023

Description

hot fix of autowarefoundation#5229

Related links

https://tier4.atlassian.net/browse/RT0-29269

Tests performed

psim test and tier4 internal evaluator has passed for pilot-auto

Also x2 test in psim was performed as the following
Screenshot from 2023-10-06 16-16-34

Notes for reviewers

BEFORE merging this PR,
https://github.com/tier4/autoware_launch.x2/pull/476
have to be merged.

Interface changes

A new parameter is required

Effects on system behavior

No longer behave exceptionally in private area.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review October 6, 2023 08:15
Copy link

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Copy link

別PRで一気に取り込んだのでクローズさせていただきます

@takayuki5168 takayuki5168 deleted the beta/v0.11.0+950805f branch October 12, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants