Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

chore: replace system config in system launch #188

Merged
merged 1 commit into from
Feb 5, 2022
Merged

chore: replace system config in system launch #188

merged 1 commit into from
Feb 5, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Feb 5, 2022

Signed-off-by: wep21 [email protected]

PR Type

  • Improvement

Related Links

https://github.com/tier4/autoware_launcher/pull/435

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

kenji-miyake
kenji-miyake approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged after #187.

@wep21 wep21 force-pushed the feature/replace-system-config branch from fbd76e7 to cb48e2c Compare February 5, 2022 16:45
@wep21 wep21 merged commit 1898e69 into tier4/universe Feb 5, 2022
@wep21 wep21 deleted the feature/replace-system-config branch February 5, 2022 16:52
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
@h-ohta
chore: replace system config in system launch (tier4#188)
d853432 
Signed-off-by: wep21 <[email protected]>
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
@tier4-autoware-private-bot
Merge pull request tier4#188 from tier4/sync-upstream
a9788b3 
chore: sync upstream
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
@kenji-miyake
Merge pull request #188 from tier4/fix-sync-rc
9ea8b5b 
Fix sync-rc workflow to work if develop branch doesn't exist
takayuki5168 added a commit that referenced this pull request May 26, 2022
@tier4-autoware-private-bot @kenji-miyake
@tier4-autoware-public-bot @YamatoAndo @wep21 @zulfaqar-azmi-t4 @taikitanaka3 @h-ohta @yukkysaito @takayuki5168 @tkimura4 @pre-commit-ci @TakumiKozaka-T4 @yn-mrse
chore: sync upstream tier4 universe (#264)
d5a275b 
* chore: fix CI settings (#182)

Signed-off-by: Kenji Miyake <[email protected]>

* chore: sync files (#180)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: sync files (#184)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: add paricle param (#181)

Signed-off-by: YamatoAndo <[email protected]>

* chore: sync files (#185)

* chore: sync files

Signed-off-by: GitHub <[email protected]>

* Update sync-files.yaml

Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* chore: sync files (#186)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: sync system config (#187)

Signed-off-by: wep21 <[email protected]>

* chore: sync files (#189)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: wep21 <[email protected]>

* chore: replace system config in system launch (#188)

Signed-off-by: wep21 <[email protected]>

* feat: adds additional configuration flags for behavior_path_planner (#171)

* feat: adds additional configuration flags for behavior_path_planner

The additional configuration is used to allows avoidance over lane with same and
different direction, as well as allows safety margin between linestring and ego.

This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496
port.

Related PR:
autowarefoundation/autoware.universe#285
autowarefoundation/autoware.universe#287

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Change lateral_collision_margion to 1.0 to reflect changes.

The decision to change the parameter value to 1.0 is made after performing
drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting
between planning control team on 3rd of February 2022.

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix: slightly increase the safety buffer.

This increases the shift length to 1.7 + 0.5 * vehicle width.

The decision to increase is based on the discussion between planning team and
also the advice from the FI team.

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* feat(behavior_velocity): add path marker visualization (#190)

Signed-off-by: tanaka3 <[email protected]>

* chore: sync files (#193)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: sync files (#194)

* chore: sync files

Signed-off-by: GitHub <[email protected]>

* chore: update workflow files name

Signed-off-by: h-ohta <[email protected]>

Co-authored-by: h-ohta <[email protected]>
Co-authored-by: h-ohta <[email protected]>

* chore: sync files (#195)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: h-ohta <[email protected]>

* feat: lateral controller param (#191)

* feat: define lat_controller_param_path

* feat: change for trajectory_follower params

* add args for lat_controller_param_path

* chore: fix wrong essential param to optional (#197)

* fix wrong param line

* move pointcloud_container_name param to optional

* fix: typo extra `>` (#199)

* Chore arrange perception rviz topics (#196)

* feat(autoware_launch): add occupancy grid vizualization

Signed-off-by: tanaka3 <[email protected]>

* feat(autoware_launch): add object recognition namespace to rviz

Signed-off-by: tanaka3 <[email protected]>

* fix: delete unused in control_launch (#200)

* fix: delete unused in control.launch.py

* fix: delete velocity_controller.param.yaml

* feat: add system_monitor parameters in sync-files (#201)

* chore: update settings of sync-files (#204)

Signed-off-by: Kenji Miyake <[email protected]>

* feat(control_launch): remove unnecessary params (#206)

Signed-off-by: Takayuki Murooka <[email protected]>

* chore: sync files (#208)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat(atutoware.rviz): disable selectable for pointcloud visualization (#207)

Signed-off-by: YamatoAndo <[email protected]>

* chore: sync files (#212)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat(behavior path planner): update params of behavior path for dynamic drivable area (#209)

* feat: load global param (#216)

* feat: load global param

Signed-off-by: wep21 <[email protected]>

* chore: add comment about rosdistro migration

Signed-off-by: wep21 <[email protected]>

* fix: add feature_remover after apollo segmentation (#217)

Signed-off-by: tomoya.kimura <[email protected]>

* chore: sync files (#222)

* chore: sync files

Signed-off-by: GitHub <[email protected]>

* Update sync-param-files.yaml

Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* chore(perception_launch): update laserscan angle increment to pandar 64 level resolution (#220)

Signed-off-by: taikitanaka <[email protected]>

* feat: add enable option for image decompressor (#224)

* feat: add enable option for image decompressor

Signed-off-by: wep21 <[email protected]>

* ci: fix flake8

Signed-off-by: wep21 <[email protected]>

* feat(behavior_velocity): add merge from private marker (#223)

* feat(behavior_velocity): add merge from private marker

Signed-off-by: tanaka3 <[email protected]>

* feat(behavior_velocity): add factor text

Signed-off-by: tanaka3 <[email protected]>

* chore: expose traffic light model path arg (#225)

Signed-off-by: wep21 <[email protected]>

* feat(autoware_launch, simulator_launch): move perception modules to simulator.launch.xml (#227)

* feat(autoware_launch, simulator_launch): move perception modules to simulator.launch.xml

Signed-off-by: Takayuki Murooka <[email protected]>

* remove unnecessary comment

Signed-off-by: Takayuki Murooka <[email protected]>

* feat(ndt_scan_matcher): add the tolerance of initial pose (#211)

* feat(ndt_scan_matcher): add the tolerance of initial pose

Signed-off-by: YamatoAndo <[email protected]>

* change param name

Signed-off-by: YamatoAndo <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: sync files (#229)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: sync files (#230)

* chore: sync files

Signed-off-by: GitHub <[email protected]>

* remove tier4/proposal

Signed-off-by: Kenji Miyake <[email protected]>

* change cron schedules

Signed-off-by: Kenji Miyake <[email protected]>

* sync sync-files.yaml

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* feat: add launch description for cpu usage adaptor (#210)

Signed-off-by: TakumiKozaka-T4 <[email protected]>

* fix: delete aip dependents (#235)

* fix: delete aip dependents

* Update package.xml

Co-authored-by: Kenji Miyake <[email protected]>

* fix: disable awapi_vehicle_get_door_topic_state_monitor (#271)

Signed-off-by: Yuma Nihei <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Yamato Ando <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: Zulfaqar Azmi <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: h-ohta <[email protected]>
Co-authored-by: h-ohta <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: TakumiKozaka-T4 <[email protected]>
Co-authored-by: Yuma Nihei <[email protected]>
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@wep21
Fix obstacle pointcloud topic name (#188)
640762f
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@tier4-autoware-private-bot @tkimura4
@rej55 @YamatoAndo @dependabot @kenji-miyake @yabuta @tier4-autoware-public-bot @pre-commit-ci @wep21 @zulfaqar-azmi-t4 @taikitanaka3 @h-ohta @yukkysaito @takayuki5168
sync upstream (#206)
cb7edec 
* update parameter (#169)

* Port pure pursuit (#166)

* Fix control.launch.py

* Apply pre-commit

* Fix control.launch.py

* Change debug topic name in rviz setting

* fix typo in localization util.launch.py (#168)

* Feature/add covarinace param (#170)

* add covariance param

* add description

* remove unused param (#172)

* Bump streetsidesoftware/cspell-action from 1.3.4 to v1 (#174)

* Bump streetsidesoftware/cspell-action from 1.3.4 to 1.5.0

Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.3.4 to 1.5.0.
- [Release notes](https://github.com/streetsidesoftware/cspell-action/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md)
- [Commits](streetsidesoftware/cspell-action@v1.3.4...v1.5.0)

---
updated-dependencies:
- dependency-name: streetsidesoftware/cspell-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update spell_check_pr.yml

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <[email protected]>

* fix: fix hdd_monitor param (#173)

* add rosbridge launch (#175)

* add rosbridge launch

* fix TODO document

add link to pull request

Co-authored-by: Kenji Miyake <[email protected]>

* fix double-byte character

Co-authored-by: Kenji Miyake <[email protected]>

* chore: sync files (#177)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* ci: update CI settings (#176)

* ci(pre-commit): update .pre-commit-config.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* ci: add sync-files.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* chore: remove old workflows

Signed-off-by: Kenji Miyake <[email protected]>

* ci(sync-upstream): update sync-upstream.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* ci(pre-commit): autofix

* style: fix for yamllint

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: minor update CI settings (#179)

Signed-off-by: Kenji Miyake <[email protected]>

* [pre-commit.ci] pre-commit autoupdate (#178)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0)
- [github.com/igorshubovych/markdownlint-cli: v0.29.0 → v0.30.0](igorshubovych/markdownlint-cli@v0.29.0...v0.30.0)
- [github.com/pre-commit/mirrors-prettier: v2.4.1 → v2.5.1](pre-commit/mirrors-prettier@v2.4.1...v2.5.1)
- [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1)
- [github.com/psf/black: 21.9b0 → 22.1.0](psf/black@21.9b0...22.1.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <[email protected]>

* chore: fix CI settings (#182)

Signed-off-by: Kenji Miyake <[email protected]>

* chore: sync files (#180)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: sync files (#184)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat: add paricle param (#181)

Signed-off-by: YamatoAndo <[email protected]>

* chore: sync files (#185)

* chore: sync files

Signed-off-by: GitHub <[email protected]>

* Update sync-files.yaml

Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* chore: sync files (#186)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: sync system config (#187)

Signed-off-by: wep21 <[email protected]>

* chore: sync files (#189)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: wep21 <[email protected]>

* chore: replace system config in system launch (#188)

Signed-off-by: wep21 <[email protected]>

* feat: adds additional configuration flags for behavior_path_planner (#171)

* feat: adds additional configuration flags for behavior_path_planner

The additional configuration is used to allows avoidance over lane with same and
different direction, as well as allows safety margin between linestring and ego.

This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496
port.

Related PR:
autowarefoundation/autoware.universe#285
autowarefoundation/autoware.universe#287

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Change lateral_collision_margion to 1.0 to reflect changes.

The decision to change the parameter value to 1.0 is made after performing
drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting
between planning control team on 3rd of February 2022.

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix: slightly increase the safety buffer.

This increases the shift length to 1.7 + 0.5 * vehicle width.

The decision to increase is based on the discussion between planning team and
also the advice from the FI team.

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* feat(behavior_velocity): add path marker visualization (#190)

Signed-off-by: tanaka3 <[email protected]>

* chore: sync files (#193)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: sync files (#194)

* chore: sync files

Signed-off-by: GitHub <[email protected]>

* chore: update workflow files name

Signed-off-by: h-ohta <[email protected]>

Co-authored-by: h-ohta <[email protected]>
Co-authored-by: h-ohta <[email protected]>

* chore: sync files (#195)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: h-ohta <[email protected]>

* feat: lateral controller param (#191)

* feat: define lat_controller_param_path

* feat: change for trajectory_follower params

* add args for lat_controller_param_path

* chore: fix wrong essential param to optional (#197)

* fix wrong param line

* move pointcloud_container_name param to optional

* fix: typo extra `>` (#199)

* Chore arrange perception rviz topics (#196)

* feat(autoware_launch): add occupancy grid vizualization

Signed-off-by: tanaka3 <[email protected]>

* feat(autoware_launch): add object recognition namespace to rviz

Signed-off-by: tanaka3 <[email protected]>

* fix: delete unused in control_launch (#200)

* fix: delete unused in control.launch.py

* fix: delete velocity_controller.param.yaml

* feat: add system_monitor parameters in sync-files (#201)

* chore: sync files (#202)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: h-ohta <[email protected]>

* chore: sync files (#203)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* chore: update settings of sync-files (#204)

Signed-off-by: Kenji Miyake <[email protected]>

* feat(control_launch): remove unnecessary params (#206)

Signed-off-by: Takayuki Murooka <[email protected]>

* chore: sync files (#208)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* feat(atutoware.rviz): disable selectable for pointcloud visualization (#207)

Signed-off-by: YamatoAndo <[email protected]>

* chore: sync files (#212)

Signed-off-by: GitHub <[email protected]>

Co-authored-by: kenji-miyake <[email protected]>

* delete vehicle parameters in longitudinal_controller.param.yaml

* apply pre-commit

* remove unused file

* update sync-param-files.yaml

* disable local_external_control in system_error_montitor_psim

Co-authored-by: Tomoya Kimura <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: YamatoAndo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: yabuta <[email protected]>
Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: Zulfaqar Azmi <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: h-ohta <[email protected]>
Co-authored-by: h-ohta <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Jan 28, 2023
@soblin
feat(intersection): add param for stuck stopline overshoot margin (#188)
c179292 
Signed-off-by: Mamoru Sobue <[email protected]>
tkimura4 added a commit that referenced this pull request Feb 2, 2023
@tier4-autoware-public-bot @kosuke55
@soblin @takayuki5168 @isamu-takagi @TakaHoribe @tkimura4
chore: sync awf/autoware_launch (#737)
2e8ddda 
* feat(autoware_launch): visualize modified_goal as PoseWithUuidStamped (#182)

Signed-off-by: kosuke55 <[email protected]>

Signed-off-by: kosuke55 <[email protected]>

* feat(intersection): improve ego velocity prediction in collision detection (#181)


Signed-off-by: Mamoru Sobue <[email protected]>

* feat(control_launch): add min_braking_distance to lane_departure_checker (#184)

Signed-off-by: kosuke55 <[email protected]>

* fix(autoware_launch): enable launch_deprecated_api (#187)

* fix(autoware_launch): enable launch_deprecated_api

Signed-off-by: Takayuki Murooka <[email protected]>

* Update autoware_launch/launch/components/tier4_autoware_api_component.launch.xml

Co-authored-by: Takagi, Isamu <[email protected]>

Signed-off-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>

* fix(behavior_path_planner): prevent pull out back twice (#176)

Signed-off-by: kosuke55 <[email protected]>

Signed-off-by: kosuke55 <[email protected]>

* feat(intersection): add param for stuck stopline overshoot margin (#188)

Signed-off-by: Mamoru Sobue <[email protected]>

* feat(mpc_lateral_controller): add steering bias removal (#190)

* feat(mpc_lateral_controller): add steering bias removal

Signed-off-by: Takamasa Horibe <[email protected]>

* change name

Signed-off-by: Takamasa Horibe <[email protected]>

Signed-off-by: Takamasa Horibe <[email protected]>

* feat: remove unused args

Signed-off-by: Takagi, Isamu <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
Co-authored-by: Mamoru Sobue <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: tomoya.kimura <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
This was referenced Feb 4, 2023
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kenji-miyake kenji-miyake kenji-miyake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wep21 @kenji-miyake