Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix: modified to reflect the argument "initial_selector_mode" in control launch (porting #496) #564

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Nov 15, 2022

PR Type

  • Improvement

Related Links

Description

porting from #496

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@h-ohta h-ohta requested a review from s-azumi November 15, 2022 09:48
@h-ohta h-ohta enabled auto-merge (squash) November 15, 2022 10:00
Copy link
Contributor

@s-azumi s-azumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit a5076ee into awf-latest Nov 15, 2022
@h-ohta h-ohta deleted the porting/496 branch November 15, 2022 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants