Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix: add obstacle stop param to launch #570

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

tkimura4
Copy link
Collaborator

Signed-off-by: tomoya.kimura [email protected]

PR Type

  • Bug Fix

Related Links

tier4/autoware_launch#539

Description

There is not cruise_planner_type arg in planning_simulator.launch.xml and logging_simulator.launch.xml, so I added it

Review Procedure

  • Set cruise_planner_type to obstacle_stop_planner/obstacle_cruise_plannerm and confirm that the autoware works well without any errors.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@takayuki5168
Copy link
Contributor

@tkimura4 In my understanding, we don't have to add this param to planning/logging simulator launch.
For example, you can try launching planning simulator with cruise_planner_type:=obstacle_cruise_planner without this PR.

Or it does not work well without this PR in the humble environment?

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 4b0cebb into awf-latest Nov 22, 2022
@tkimura4 tkimura4 deleted the fix/obstacle_stop_type_arg branch November 22, 2022 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants